Use correct log functions for std::format to work #10035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Apr 15, 2025
| @@ -142,7 +142,7 @@ abort_if_negative_integer_argument (int arg, const char *arg_name, std::source_l | |||
| [[gnu::always_inline]] | |||
| inline void pd_log_location (std::source_location sloc = std::source_location::current ()) noexcept | |||
| { | |||
| log_info_nocheck (LOG_DEFAULT, "loc: {}:{} ('{}')", sloc.file_name (), sloc.line (), sloc.function_name ()); | |||
| log_warn (LOG_DEFAULT, "loc: {}:{} ('{}')", sloc.file_name (), sloc.line (), sloc.function_name ()); | |||
There was a problem hiding this comment.
why change from "info" to "warn"?
jonpryor
reviewed
Apr 15, 2025
| @@ -142,7 +142,7 @@ abort_if_negative_integer_argument (int arg, const char *arg_name, std::source_l | |||
| // of the calls present. | |||
| force_inline inline void pd_log_location (std::source_location sloc = std::source_location::current ()) noexcept | |||
| { | |||
| log_info_nocheck (LOG_DEFAULT, "loc: {}:{} ('{}')", sloc.file_name (), sloc.line (), sloc.function_name ()); | |||
| log_warn (LOG_DEFAULT, "loc: {}:{} ('{}')", sloc.file_name (), sloc.line (), sloc.function_name ()); | |||
There was a problem hiding this comment.
why change from "info" to "warn"?
There was a problem hiding this comment.
log_info_nocheck_fmt caused the code to fail to compile and I didn't want to make the PR bigger than it needs to be. This is a debugging function not used anywhere in the code (I use it for logging locally sometimes), so log_warn works just as fine as log_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.