Skip to content

[main] fix Microsoft.NET.Sdk.Android.Manifest-* version band #10120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

jonathanpeppers
Copy link
Member

"Forward port" of: #10112

Bringing this to main, so we won't have the same problem with a .NET 10.0.200/300 SDK.

In fc72bb4, we migrated to a 9.0.300 .NET SDK, which unfortunately resulted in an Android workload manifest with a 9.0.300 version band:

Microsoft.NET.Sdk.Android.Manifest-9.0.300.35.0.73.nupkg

To stay on 9.0.100, we need should use $(DotNetAndroidManifestVersionBand) for the manifest version band instead of $(DotNetSdkManifestsFolder).

I also had to make a similar change in DotNet.targets.

Backport of: #10112

In fc72bb4, we migrated to a 9.0.300 .NET SDK, which unfortunately
resulted in an Android workload manifest with a 9.0.300 version band:

    Microsoft.NET.Sdk.Android.Manifest-9.0.300.35.0.73.nupkg

To stay on 9.0.100, we need should use `$(DotNetAndroidManifestVersionBand)`
for the manifest version band instead of `$(DotNetSdkManifestsFolder)`.

I also had to make a similar change in `DotNet.targets`.
@jonathanpeppers jonathanpeppers marked this pull request as ready for review May 7, 2025 18:12
@jonathanpeppers jonathanpeppers requested a review from jonpryor as a code owner May 7, 2025 18:12
@jonathanpeppers jonathanpeppers requested a review from pjcollins May 7, 2025 18:12
@jonathanpeppers jonathanpeppers merged commit fc296cd into main May 7, 2025
59 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/10112-backport branch May 7, 2025 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants