[Mono.Android] update return type of GetHttpMessageHandler()
#10212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/runtime#116707 To prevent a `#if TARGET_ANDROID` in dotnet/runtime: #if TARGET_ANDROID using GetHttpMessageHandlerReturnType = object; #elif TARGET_IOS || TARGET_MACCATALYST || TARGET_TVOS using GetHttpMessageHandlerReturnType = System.Net.Http.HttpMessageHandler; #endif Let's unify and use `System.Net.Http.HttpMessageHandler` as the return type for `GetHttpMessageHandler()`.
rolfbjarne
approved these changes
Jun 17, 2025
| @@ -355,7 +356,7 @@ static object GetHttpMessageHandler () | |||
| httpMessageHandlerType = handlerType; | |||
| } | |||
|
|
|||
| return Activator.CreateInstance (httpMessageHandlerType) | |||
| return (HttpMessageHandler) Activator.CreateInstance (httpMessageHandlerType) | |||
There was a problem hiding this comment.
There's a comment a bit above that says "We don't do any type checking or casting here to avoid dependency on System.Net.Http in Mono.Android.dll" - this sounds like something from Mono days, when we wouldn't want a cyclic reference between Mono.Android.dll and System.Net.Http.dll. This shouldn't be a problem anymore (so maybe remove the comment?)
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Jun 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#116707
To prevent a
#if TARGET_ANDROIDin dotnet/runtime:Let's unify and use
System.Net.Http.HttpMessageHandleras the return type forGetHttpMessageHandler().