[Xamarin.Android.Build.Tasks] update <Proguard /> task for latest acw-map.txt file #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-map.txt file Fixes dotnet#1373 Since dotnet#1131, the contents of the `acw-map.txt` file have changed. We have removed the fully qualified type names from the file, and there is some code in the `<Proguard />` task that relies on a specific number of lines per C# type. We need to update the for-loop to skip every third line instead of every fourth line. I also updated the loop to only index against the `acwLines` array once per loop interation, as a small performance improvement. The code is also a little more readable from this change. Lastly, I added some code to the proguard test so that it validates the proguard configuration file contains the appropriate contents. Prior to this, the test was only making sure the build succeeded.
jonpryor
pushed a commit
that referenced
this pull request
Mar 16, 2018
Fixes: #1373 Since e5b1c92, the contents of the `acw-map.txt` file have changed. We have removed the fully qualified type names from the file, and there is some code in the `<Proguard />` task that relies on a specific number of lines per C# type. We need to update the for-loop to skip every third line instead of every fourth line. I also updated the loop to only index against the `acwLines` array once per loop interation, as a small performance improvement. The code is also a little more readable from this change. Lastly, I added some code to the proguard test so that it validates the proguard configuration file contains the appropriate contents. Prior to this, the test was only making sure the build succeeded.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1373
Since #1131, the contents of the
acw-map.txtfile have changed. Wehave removed the fully qualified type names from the file, and there is
some code in the
<Proguard />task that relies on a specific number oflines per C# type.
We need to update the for-loop to skip every third line instead of every
fourth line.
I also updated the loop to only index against the
acwLinesarray onceper loop interation, as a small performance improvement. The code is also
a little more readable from this change.
Lastly, I added some code to the proguard test so that it validates the
proguard configuration file contains the appropriate contents. Prior to
this, the test was only making sure the build succeeded.