Generator do not expose nonpublic #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adjuster. api-24.xml.in was already generated with the almost latest tools, but it has some new members probably due to android.jar updates. Others were generated by old tools so they had extraneous generic constraints.
…ster. There were non-breaking API definition files changes caused by dotnet/java-interop#94 This update reflects the changes.
atsushieno
force-pushed
the
generator-do-not-expose-nonpublic
branch
from
7ccc864 to
5847c2d
Compare
|
Aside: it would be nice if GitHub would actually show the changes. Fortunately, there's the Many of the changes are due to: - <typeParameter name="V">
- <genericConstraints>
- <genericConstraint type="java.lang.Object">
- </genericConstraint>
- </genericConstraints>
- </typeParameter>
+ <typeParameter name="V"></typeParameter>which seems odd, but should be meaningless. |
|
Should this include a corresponding Java.Interop bump? It wouldn't be strictly required, since we're not using |
|
The genericConstraints changes were from older ApiXmlAdjuster fix (they were different from jar2xml outputs which never generated those extraneous elements), not by that Java.Interop changeset. |
radical
pushed a commit
that referenced
this pull request
May 8, 2018
While reviewing [DoNotThrowInUnexpectedLocationRule][throw] regarding `JniArrayElements.Elements` we discussed the issue and came up with a slight semantic API overhaul. [throw]: https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Exceptions.DoNotThrowInUnexpectedLocationRule(2.10) Previously, we had: public abstract partial class JniArrayElements : IDisposable { public IntPtr Elements {get;} public void CopyToJava(); public void Dispose(); public void Release(JniReleaseArrayElementsMode releaseMode); } public sealed class JniInt32ArrayElements : JniArrayElements { public new unsafe int* Elements {get;} } The *idea* of `JniArrayElements` was that it refers to a contiguous blob of memory, starting at address `JniArrayElements.Elements`. The thinking was that `JniArrayElements` would allow reading or otherwise manipulating the memory regions without needing to know the underlying element type. On further discussion, this abstraction was missing something important: the *size* of the region of memory that `JniArrayElements.Elements` refers to. Additionally, with the advent of [C# 7 ref returns][rr], we thought that providing a ref-return indexer would be preferable to using a shadowing/re-declared `Elements` property. [rr]: https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/ref-returns We also considered using `Span<T>/Memory<T>`; it is not available in mono at this time. It should be possible to add support for them when they are supported. With these changes, the updated public API is: public abstract partial class JniArrayElements : IDisposable { public IntPtr Elements {get;} public int Size {get;} public void CopyToJava(); public void Dispose(); public void Release(JniReleaseArrayElementsMode releaseMode); } public sealed class JniInt32ArrayElements : JniArrayElements { public ref int this [int index] {get;} }
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.