[Mono.Android] Generate default interface members for API-30+. #4353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
monoandroid-csharp8
branch
from
15c0723 to
4c89765
Compare
jpobst
force-pushed
the
monoandroid-csharp8
branch
from
4c89765 to
9046473
Compare
gugavaro
approved these changes
Mar 5, 2020
This was referenced Mar 5, 2020
jonpryor
added a commit
that referenced
this pull request
Mar 6, 2020
Context: dotnet/java-interop#509 Use `generator --lang-features=default-interface-methods` so that we start binding [Java interface default methods][0] within `android.jar` and `Mono.Android.dll`, for API-R. *Note*: `Microsoft.DotNet.ApiCompat.exe` does not currently understand C#8 [default interface members][1], which we use to bind Java interface default methods. As such, it reports an error for *every added* default interface member, e.g. InterfacesShouldHaveSameMembers : Interface member 'Android.App.Application.IActivityLifecycleCallbacks.OnActivityPostCreated(Android.App.Activity, Android.OS.Bundle)' is present in the implementation but not in the contract. We are investigating improving `Microsoft.DotNet.ApiCompat.exe` so that it doesn't report such changes as incompatible. [0]: https://docs.oracle.com/javase/tutorial/java/IandI/defaultmethods.html [1]: https://github.com/dotnet/csharplang/blob/f7952cdddf85316a4beec493a0ecc14fcb3241c8/proposals/csharp-8.0/default-interface-methods.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#509
Using the new features provided by C#8 to provide bindings that mirror the original Java
android.jarmore closely.Step 1 - Default Interface Members
Enable
--lang-features=default-interface-methodsto start generatingdefaultmethods on all interfaces inMono.Android.dllAPI-30+.