[build] Build Xamarin.Android.NUniteLite against v2.3 #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=54785 The scenario: build `Xamarin.Android.NUnitLite.dll` against API-Y, use it in an app using `Mono.Android.dll` API-X, X < Y. (Specifically, build `Xamarin.Android.NUnitLite.dll` against API-19, and the app against API-10.) If you build this in a Release configuration, or otherwise attempt to link the assemblies, Linking will fail: error XA2006: Could not resolve reference to 'System.String Android.OS.Environment::get_DirectoryDocuments()' (defined in assembly 'Xamarin.Android.NUnitLite, Version=1.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065') with scope 'Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065'. Commit 3ed220d fixed a similar issue wrt `BaseBundle`, but only lowered `Y` to `19`. Since we still support Apps targeting API-10, this is still problematic. Update the `make framework-assemblies` target so that instead of hardcoding the `Xamarin.Android.NUnitLite.dll` "rebuild" to use API-19, instead use `$(firstword $(API_LEVELS))` -- which is currently API-10/v2.3 -- so that as we "bump" up our minimum supported API level we can progressively include API features.
jonpryor
force-pushed
the
jonp-nunit-api-10
branch
from
7b5c3cb to
84b8311
Compare
jonpryor
added a commit
that referenced
this pull request
Apr 10, 2017
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=54785 The scenario: build `Xamarin.Android.NUnitLite.dll` against API-Y, use it in an app using `Mono.Android.dll` API-X, X < Y. (Specifically, build `Xamarin.Android.NUnitLite.dll` against API-19, and the app against API-10.) If you build this in a Release configuration, or otherwise attempt to link the assemblies, Linking will fail: error XA2006: Could not resolve reference to 'System.String Android.OS.Environment::get_DirectoryDocuments()' (defined in assembly 'Xamarin.Android.NUnitLite, Version=1.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065') with scope 'Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065'. Commit 3ed220d fixed a similar issue wrt `BaseBundle`, but only lowered `Y` to `19`. Since we still support Apps targeting API-10, this is still problematic. Update the `make framework-assemblies` target so that instead of hardcoding the `Xamarin.Android.NUnitLite.dll` "rebuild" to use API-19, instead use `$(firstword $(API_LEVELS))` -- which is currently API-10/v2.3 -- so that as we "bump" up our minimum supported API level we can progressively include API features.
jonpryor
added a commit
that referenced
this pull request
Jan 8, 2020
Changes: dotnet/java-interop@3bf5333...c0cc770 Fixes: dotnet/java-interop#525 Fixes: dotnet/java-interop#543 * dotnet/java-interop@c0cc770: [generator] Support Kotlin's unsigned types (#539) (#553) * dotnet/java-interop@5009f32: [generator] Improve generic type lookup (#552)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=54785
The scenario: build
Xamarin.Android.NUnitLite.dllagainst API-Y,use it in an app using
Mono.Android.dllAPI-X, X < Y.(Specifically, build
Xamarin.Android.NUnitLite.dllagainst API-19,and the app against API-10.)
If you build this in a Release configuration, or otherwise attempt to
link the assemblies, Linking will fail:
Commit 3ed220d fixed a similar issue wrt
BaseBundle, but onlylowered
Yto19. Since we still support Apps targeting API-10,this is still problematic.
Update the
make framework-assembliestarget so that instead ofhardcoding the
Xamarin.Android.NUnitLite.dll"rebuild" to useAPI-19, instead use
$(firstword $(API_LEVELS))-- which is currentlyAPI-10/v2.3 -- so that as we "bump" up our minimum supported API level
we can progressively include API features.