[Xamarin.Android.Build.Tasks] Crash - NetStandard library - could not load assembly during startup registration. #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
dellis1972
force-pushed
the
Bug57342
branch
3 times, most recently
from
7c93527 to
8bf82bd
Compare
|
build |
1 similar comment
|
build |
|
@jonpryor looks like the new |
|
@dellis1972: I'm still not sure how that explains the |
|
There's a failure in |
|
@jonpryor That unit test has a problem.. I'm gonna fix it in a new PR |
… load assembly during startup registration. Context https://bugzilla.xamarin.com/show_bug.cgi?id=57342 The investigation in the bug suggests that we are pickin up a reference assembly rather than a the actual implementation. This is to do with the way netstandard nuget packages work, they include both 'ref' and 'lib' folders. In this case 'ref' was being included in the package rather than 'lib'. This commit alters the `_ResolveAssemblies` to use `@(ReferenceCopyLocalPaths)` This ItemGroup is populated with the correct items.
jonpryor
pushed a commit
that referenced
this pull request
Aug 4, 2017
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=57342 The investigation in the bug suggests that we are picking up a reference assembly rather than a the actual implementation. This is to do with the way netstandard nuget packages work, they include both `ref` and `lib` folders. In this case `ref` was being included in the package rather than `lib`. This commit alters the `_ResolveAssemblies` to use @(ReferenceCopyLocalPaths) This ItemGroup is populated with the correct items.
jonpryor
added a commit
that referenced
this pull request
Aug 9, 2017
…ies (#706)" This reverts commit d15-4/0bd26fd3c19fb973316172c10aa2c9e9ae43c1e3. Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58679 Turns Out™ that `@(ReferenceCopyLocalPaths)` isn't a "drop-in" replacement for `@(ReferencePaths)`: `@(ReferenceCopyLocalPaths)` doesn't contain `Mono.Android.Export.dll`, which means that every app which uses `Mono.Android.Export.dll` and properly contains a `<Reference Include="Mono.Android.Export" />` now elicits the packaging error: error XA4210: You need to add a reference to Mono.Android.Export.dll when you use ExportAttribute or ExportFieldAttribute. Revert the fix for now until we can create a better fix.
radekdoulik
added a commit
to radekdoulik/xamarin-android
that referenced
this pull request
Sep 9, 2020
To get "[jnimarshalmethod-gen] Fix type resolution crash (dotnet#706)" fix.
radekdoulik
added a commit
to radekdoulik/xamarin-android
that referenced
this pull request
Sep 10, 2020
To get "[jnimarshalmethod-gen] Fix type resolution crash (dotnet#706)" fix.
jonpryor
pushed a commit
that referenced
this pull request
Oct 20, 2020
Fixes: dotnet/java-interop#461 Fixes: dotnet/java-interop#682 Fixes: dotnet/java-interop#717 Fixes: dotnet/java-interop#719 Fixes: dotnet/java-interop#728 Changes: dotnet/java-interop@ac914ce...b991bb8 * dotnet/java-interop@b991bb86: [generator] Revert change to use auto-properties in EventArgs classes (#736) * dotnet/java-interop@ee50d89b: Bump to xamarin/xamarin-android-tools/master@f2af06f2 (#733) * dotnet/java-interop@a0b895c1: [build] Suppress NuGet warnings (#730) * dotnet/java-interop@8b1b0507: [generator] Fix parsing of complex generic types (#729) * dotnet/java-interop@ee7afeed: [generator] Prevent generating duplicate EventArgs classes (#726) * dotnet/java-interop@1f21f38c: [generator] Use GC.KeepAlive for reference type method parameters. (#725) * dotnet/java-interop@5136ef98: [Xamarin.Android.Tools.Bytecode] Hide Kotlin nested types inside (#723) * dotnet/java-interop@53d60513: [jnimarshalmethod-gen] Fix registration on Windows (#721) * dotnet/java-interop@5a834d42: [jnimarshalmethod-gen] Avoid creating AppDomains (#720) * dotnet/java-interop@a76edb8c: [Xamarin.Android.Tools.ApiXmlAdjuster] Find app.android.IntentService (#718) * dotnet/java-interop@6cde0877: [Java.Interop] Emit a reference assembly for Java.Interop.dll (#716) * dotnet/java-interop@b858dc59: [generator] Provide line/col numbers for api.xml warnings (#715) * dotnet/java-interop@9be92a04: [ci] Don't kick off CI for documentation only changes. (#712) * dotnet/java-interop@03c22722: [jnimarshalmethod-gen] Fix type resolution crash (#706)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://bugzilla.xamarin.com/show_bug.cgi?id=57342
The investigation in the bug suggests that we are pickin up a
reference assembly rather than a the actual implementation.
This is to do with the way netstandard nuget packages work, they
include both 'ref' and 'lib' folders.
In this case 'ref' was being included in the package rather than
'lib'. This commit alters the
_ResolveAssembliesto useThis ItemGroup is populated with the correct items.
We also add a new Warning to detect if we attempt to package a reference assembly.