[Build Tasks] Import mono linker sources #8482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Xamarin.Android.Build.Tasks` and `Microsoft.Android.Sdk.ILLink` projects have been updated to only compile the linker sources that they require, rather than including everything from the `src/Xamarin.Android.Build.Tasks/Linker` folder. Linker sources from mono/mono@6dd9def have been added to `src/Xamarin.Android.Build.Tasks/Linker/External`. Adding the dozen or so files we still depend on directly to the repo removes one of the last dependencies we still have on the mono bundle. The `LinkAssembliesNoShrink` task is the main piece of XABT that depends on these mono linker sources. In the future we should try to see if we migrate this tasks functionality to some ILLink tool/task invocation.
pjcollins
force-pushed
the
dev/pjc/monolinkersrc
branch
from
9c3d7c5 to
92c8a9c
Compare
pjcollins
requested review from
jonpryor,
dellis1972 and
jonathanpeppers
as code owners
grendello
approved these changes
Nov 7, 2023
jonathanpeppers
approved these changes
Nov 7, 2023
dellis1972
approved these changes
Nov 8, 2023
|
The MicrosoftIntune(False) failure is not local to this PR, we'll need to investigate that separately as it's also failing on main. |
|
The Intune team shipped a release today, they say it might fix that test: #8495 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Xamarin.Android.Build.TasksandMicrosoft.Android.Sdk.ILLinkprojects have been updated to only compile the linker sources that they
require, rather than including everything from the
src/Xamarin.Android.Build.Tasks/Linkerfolder.Linker sources from mono/mono@6dd9def
have been added to
src/Xamarin.Android.Build.Tasks/Linker/External.Adding the couple dozen files we still depend on directly to the repo
removes one of the last dependencies we have on the mono bundle.
The
LinkAssembliesNoShrinktask is the main piece of XABT that dependson these mono linker sources. In the future we should try to see if we
can migrate this tasks functionality to some ILLink tool/task invocation.