[Xamarin.Android.Build.Tasks] make designer MSBuild targets a no-op #9473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://developercommunity.visualstudio.com/t/XamarinAndroid-Designer---Replacement/10728132 As the Android designer is no longer supported in Visual Studio, we can remove the MSBuild logic for the following targets: * `GetExtraLibraryLocationsForDesigner` * `SetupDependenciesForDesigner` Since these are public MSBuild target names, we should probably leave them in and "do nothing". This also will simplify things if we ever refactor `<GenerateJavaStubs/>` and friends as this removes a caller. I also removed the `DesignerTests.cs` file that was testing these.
jonathanpeppers
commented
Oct 30, 2024
| <_MergedManifestDocuments Condition=" '$(AndroidManifestMerger)' == 'legacy' " Include="@(ExtractedManifestDocuments)" /> | ||
| </ItemGroup> | ||
|
|
||
| <GenerateJavaStubs |
There was a problem hiding this comment.
I would like to refactor this target soon (potentially moving it into a trimmer step), so removing a caller is nice!
jonathanpeppers
requested review from
mcumming,
jonpryor and
dellis1972
as code owners
dellis1972
approved these changes
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://developercommunity.visualstudio.com/t/XamarinAndroid-Designer---Replacement/10728132
As the Android designer is no longer supported in Visual Studio, we can remove the MSBuild logic for the following targets:
GetExtraLibraryLocationsForDesignerSetupDependenciesForDesignerSince these are public MSBuild target names, we should probably leave them in and "do nothing".
This also will simplify things if we ever refactor
<GenerateJavaStubs/>and friends as this removes a caller.I also removed the
DesignerTests.csfile that was testing these.