Skip to content

[Xamarin.Android.Build.Tasks] Null Reference Exceoption when getting android.jar #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2017
Merged

[Xamarin.Android.Build.Tasks] Null Reference Exceoption when getting android.jar #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd0b4c4
[Xamarin.Android.Build.Tasks] Null Reference Exceoption when getting …
dellis1972 Oct 25, 2017
6abd2b0
Updated based on feedback
dellis1972 Oct 31, 2017
3c14b9f
"XA1234" was a silly example. Use better value.
jonpryor Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions src/Xamarin.Android.Build.Tasks/Tasks/GetJavaPlatformJar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,24 +69,16 @@ public override bool Execute ()
}

platform = GetTargetSdkVersion (platform, target_sdk);
JavaPlatformJarPath = Path.Combine (MonoAndroidHelper.AndroidSdk.TryGetPlatformDirectoryFromApiLevel (platform, MonoAndroidHelper.SupportedVersions), "android.jar");

if (!File.Exists (JavaPlatformJarPath)) {
Log.LogError ("Could not find android.jar for API Level {0}. " +
"This means the Android SDK platform for API Level {0} is not installed. " +
"Either install it in the Android SDK Manager (Tools > Open Android SDK Manager...), " +
"or change your Xamarin.Android project to target an API version that is installed. " +
"({1} missing.)",
platform, JavaPlatformJarPath);
return false;
}
JavaPlatformJarPath = MonoAndroidHelper.TryGetAndroidJarPath (Log, platform);
if (JavaPlatformJarPath == null)
return !Log.HasLoggedErrors;

TargetSdkVersion = platform;

Log.LogDebugMessage (" [Output] JavaPlatformJarPath: {0}", JavaPlatformJarPath);
Log.LogDebugMessage (" [Output] TargetSdkVersion: {0}", TargetSdkVersion);

return true;
return !Log.HasLoggedErrors;
}

string GetTargetSdkVersion (string target, XAttribute target_sdk)
Expand Down
9 changes: 3 additions & 6 deletions src/Xamarin.Android.Build.Tasks/Tasks/JarToXml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,9 @@ public override bool Execute ()
}

// Ensure that the user has the platform they are targeting installed
var jarpath = Path.Combine (MonoAndroidHelper.AndroidSdk.TryGetPlatformDirectoryFromApiLevel (AndroidApiLevel, MonoAndroidHelper.SupportedVersions), "android.jar");

if (!File.Exists (jarpath)) {
Log.LogError ("Could not find android.jar for API Level {0}. This means the Android SDK platform for API Level {0} is not installed. Either install it in the Android SDK Manager, or change your Android Bindings project to target an API version that is installed. ({1} missing.)", AndroidApiLevel, jarpath);
return false;
}
var jarpath = MonoAndroidHelper.TryGetAndroidJarPath (Log, AndroidApiLevel);
if (jarpath == null)
return !Log.HasLoggedErrors;

// Ensure that all requested jars exist
foreach (var jar in SourceJars)
Expand Down
16 changes: 16 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Utilities/MonoAndroidHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,5 +530,21 @@ public static IEnumerable<string> Executables (string executable)
foreach (var ext in pathExts)
yield return Path.ChangeExtension (executable, ext);
}

public static string TryGetAndroidJarPath (TaskLoggingHelper log, string platform)
{
var platformPath = MonoAndroidHelper.AndroidSdk.TryGetPlatformDirectoryFromApiLevel (platform, MonoAndroidHelper.SupportedVersions);
if (platformPath == null) {
var expectedPath = MonoAndroidHelper.AndroidSdk.GetPlatformDirectoryFromId (platform);
log.LogError ("XA5207", "Could not find android.jar for API Level {0}. " +
"This means the Android SDK platform for API Level {0} is not installed. " +
"Either install it in the Android SDK Manager (Tools > Open Android SDK Manager...), " +
"or change your Xamarin.Android project to target an API version that is installed. " +
"({1} missing.)",
platform, Path.Combine (expectedPath, "android.jar"));
return null;
}
return Path.Combine (platformPath, "android.jar");
}
}
}