Skip to content

[Xamarin.Android.Build.Tasks] introduce $(_AndroidJcwCodegenTarget) #9858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Feb 27, 2025

d70db5b was wrong in that it merged two different things:

  • Java stub generation's "codegen target" (once settable by an MSBuild property $(_AndroidCodeGenerationTarget))

  • C# generator's "codegen target" or $(AndroidCodegenTarget)

The problem was $(_AndroidCodeGenerationTarget) was just poorly named making me think it was the same as $(AndroidCodegenTarget).

Partially revert d70db5b and use the name $(_AndroidJcwCodegenTarget) instead.

NativeAOT now defaults to $(_AndroidJcwCodegenTarget)=JavaInterop1 and $(AndroidCodegenTarget)=XAJavaInterop1.

d70db5b was *wrong* in that it merged two different things:

* Java stub generation's "codegen target" (now settable by an MSBuild
  property `$(_AndroidCodeGenerationTarget)`)

* C# generator's "codegen target" or `$(AndroidCodegenTarget)`

The problem was `$(_AndroidCodeGenerationTarget)` was just poorly
named making me think it was the same as `$(AndroidCodegenTarget)`.

Partially revert d70db5b and use the name
`$(_AndroidJcwCodegenTarget)` instead.

NativeAOT now defaults to `$(_AndroidJcwCodegenTarget)=JavaInterop1`
and `$(AndroidCodegenTarget)=XAJavaInterop1`.
@jonathanpeppers jonathanpeppers force-pushed the dev/peppers/_AndroidJcwCodegenTarget branch from 0b969ba to 307d8e5 Compare February 27, 2025 18:10
@jonpryor jonpryor merged commit 0edc16d into main Feb 28, 2025
58 checks passed
@jonpryor jonpryor deleted the dev/peppers/_AndroidJcwCodegenTarget branch February 28, 2025 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants