[NativeAOT] Improve managed type map #9909
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #9856
#9846 showed that several tests are failing with the new managed type map. This PR addresses two of these issues:
JavaList
andJavaList<object>
both map tojava/util/ArrayList
)java/util/ArrayList
toJavaList
instead ofJavaList<>
)These changes now break roundtripping (
JavaList<T>
->java/util/ArrayList
->JavaList
). This broke the current way of checking for hash collisions. I haven't figured out a good way to replace these checks. Since we aren't checking hash collisions in native type maps, maybe we don't need to do the collision checks in the managed type map either.