[xaprepare] log exceptions, and handle CRL check failures #9965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
dev/peppers/xapreparelogging
branch
from
2dbf6bd to
db04004
Compare
jonathanpeppers
changed the title
Context: dotnet/arcade#15546 Right now failures just print: Downloading dotnet-install script... -> https://builds.dotnet.microsoft.com/dotnet/scripts/v1/dotnet-install.sh Error: Download of dotnet-install from 'https://builds.dotnet.microsoft.com/dotnet/scripts/v1/dotnet-install.sh' failed Let's log the exception message, as it retries. After this change, we get the intermittent error on macOS only: Warning: Download of 'https://builds.dotnet.microsoft.com/dotnet/scripts/v1/dotnet-install.sh' failed: System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception. ---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid because of errors in the certificate chain: RevocationStatusUnknown In dotnet/arcade#15546, they addressed this problem by using `SocketsHttpHandler` and configuring the `CertificateChainPolicy` to ignore the `RevocationStatusUnknown` error. Let's use the same approach here.
jonathanpeppers
force-pushed
the
dev/peppers/xapreparelogging
branch
from
db04004 to
c96acd2
Compare
dellis1972
approved these changes
Mar 25, 2025
pjcollins
approved these changes
Mar 25, 2025
jonathanpeppers
added a commit
that referenced
this pull request
Mar 26, 2025
Context: dotnet/arcade#15546 Right now failures just print: Downloading dotnet-install script... -> https://builds.dotnet.microsoft.com/dotnet/scripts/v1/dotnet-install.sh Error: Download of dotnet-install from 'https://builds.dotnet.microsoft.com/dotnet/scripts/v1/dotnet-install.sh' failed Let's log the exception message, as it retries. After this change, we get the intermittent error on macOS only: Warning: Download of 'https://builds.dotnet.microsoft.com/dotnet/scripts/v1/dotnet-install.sh' failed: System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception. ---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid because of errors in the certificate chain: RevocationStatusUnknown In dotnet/arcade#15546, they addressed this problem by using `SocketsHttpHandler` and configuring the `CertificateChainPolicy` to ignore the `RevocationStatusUnknown` error. Let's use the same approach here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/arcade#15546
Right now failures just print:
Let's log the exception message, as it retries.
After this change, we get the intermittent error on macOS only:
In dotnet/arcade#15546, they addressed this problem by using
SocketsHttpHandlerand configuring theCertificateChainPolicytoignore the
RevocationStatusUnknownerror.Let's use the same approach here.