-
Notifications
You must be signed in to change notification settings - Fork 555
[tests] fix InstallAndroidDependenciesTest("GoogleV2")
#9986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has started failing as soon as a `platform-tools` 36.0.0 appeared on Google's feed: _AndroidSdkDirectory was not set to new SDK path C:\a\_work\1\a\TestRelease\03-28_03.15.36\temp\InstallAndroidDependenciesTestGoogleV2\android-sdk. Please check the task output in 'install-deps.log' Expected: True But was: False I'm guessing this is because it is still "preview": <remotePackage path="platform-tools"> <type-details xsi:type="generic:genericDetailsType"/> <revision> <major>36</major> <minor>0</minor> <micro>0</micro> </revision> <display-name>Android SDK Platform-Tools</display-name> <uses-license ref="android-sdk-preview-license"/> As the `.binlog` shows: Component Android SDK Platform-Tools r36.0.0 not present on the system Component Android SDK Platform-Tools r35.0.2 not present on the system And then the next build refuses to use the SDK, due to `adb.exe` missing? ValidateAndroidSdkLocation: for locator=constructor param, path=`C:\a\_work\1\a\TestRelease\03-28_03.15.36\temp\InstallAndroidDependenciesTestGoogleV2\android-sdk`, result=False ValidateAndroidSdkLocation: for locator=preferred path, path=``, result=False Looking for Android SDK... ValidateAndroidSdkLocation: for locator=all paths, path=`C:\Android\android-sdk`, found adb `C:\Android\android-sdk\platform-tools\adb.EXE` ... ResolveSdks Outputs: AndroidSdkPath: C:\Android\android-sdk If I change the `GetCurrentPlatformToolsVersion()` method to ignore entries with: <uses-license ref="android-sdk-preview-license"/> Then the test passes for me locally. It seems reasonable to ignore "preview" versions of `platform-tools` for this test.
dellis1972
approved these changes
Mar 28, 2025
jonathanpeppers
added a commit
that referenced
this pull request
Mar 31, 2025
This test has started failing as soon as a `platform-tools` 36.0.0 appeared on Google's feed: _AndroidSdkDirectory was not set to new SDK path C:\a\_work\1\a\TestRelease\03-28_03.15.36\temp\InstallAndroidDependenciesTestGoogleV2\android-sdk. Please check the task output in 'install-deps.log' Expected: True But was: False I'm guessing this is because it is still "preview": <remotePackage path="platform-tools"> <type-details xsi:type="generic:genericDetailsType"/> <revision> <major>36</major> <minor>0</minor> <micro>0</micro> </revision> <display-name>Android SDK Platform-Tools</display-name> <uses-license ref="android-sdk-preview-license"/> As the `.binlog` shows: Component Android SDK Platform-Tools r36.0.0 not present on the system Component Android SDK Platform-Tools r35.0.2 not present on the system And then the next build refuses to use the SDK, due to `adb.exe` missing? ValidateAndroidSdkLocation: for locator=constructor param, path=`C:\a\_work\1\a\TestRelease\03-28_03.15.36\temp\InstallAndroidDependenciesTestGoogleV2\android-sdk`, result=False ValidateAndroidSdkLocation: for locator=preferred path, path=``, result=False Looking for Android SDK... ValidateAndroidSdkLocation: for locator=all paths, path=`C:\Android\android-sdk`, found adb `C:\Android\android-sdk\platform-tools\adb.EXE` ... ResolveSdks Outputs: AndroidSdkPath: C:\Android\android-sdk If I change the `GetCurrentPlatformToolsVersion()` method to ignore entries with: <uses-license ref="android-sdk-preview-license"/> Then the test passes for me locally. It seems reasonable to ignore "preview" versions of `platform-tools` for this test.
jonpryor
pushed a commit
that referenced
this pull request
Apr 7, 2025
This test has started failing as soon as a `platform-tools` 36.0.0 appeared on Google's feed: _AndroidSdkDirectory was not set to new SDK path C:\a\_work\1\a\TestRelease\03-28_03.15.36\temp\InstallAndroidDependenciesTestGoogleV2\android-sdk. Please check the task output in 'install-deps.log' Expected: True But was: False I'm guessing this is because it is still "preview": <remotePackage path="platform-tools"> <type-details xsi:type="generic:genericDetailsType"/> <revision> <major>36</major> <minor>0</minor> <micro>0</micro> </revision> <display-name>Android SDK Platform-Tools</display-name> <uses-license ref="android-sdk-preview-license"/> As the `.binlog` shows: Component Android SDK Platform-Tools r36.0.0 not present on the system Component Android SDK Platform-Tools r35.0.2 not present on the system And then the next build refuses to use the SDK, due to `adb.exe` missing? ValidateAndroidSdkLocation: for locator=constructor param, path=`C:\a\_work\1\a\TestRelease\03-28_03.15.36\temp\InstallAndroidDependenciesTestGoogleV2\android-sdk`, result=False ValidateAndroidSdkLocation: for locator=preferred path, path=``, result=False Looking for Android SDK... ValidateAndroidSdkLocation: for locator=all paths, path=`C:\Android\android-sdk`, found adb `C:\Android\android-sdk\platform-tools\adb.EXE` ... ResolveSdks Outputs: AndroidSdkPath: C:\Android\android-sdk If I change the `GetCurrentPlatformToolsVersion()` method to ignore entries with: <uses-license ref="android-sdk-preview-license"/> Then the test passes for me locally. It seems reasonable to ignore "preview" versions of `platform-tools` for this test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has started failing as soon as a
platform-tools
36.0.0 appeared on Google's feed:I'm guessing this is because it is still "preview":
As the
.binlog
shows:And then the next build refuses to use the SDK, due to
adb.exe
missing?If I change the
GetCurrentPlatformToolsVersion()
method to ignore entries with:Then the test passes for me locally.
It seems reasonable to ignore "preview" versions of
platform-tools
for this test.