[release/10.0.1xx-preview3] [Mono.Android] prefix Microsoft.Android.Runtime namespace with _
#9998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Runtime` namespace with `_`
We introduced a new `internal` type in `Mono.Android.dll`:
namespace Microsoft.Android.Runtime;
class ManagedValueManager : JniRuntime.JniValueManager
Causes various C# compiler errors in dotnet/maui:
D:\src\maui\src\Essentials\src\AppActions\AppActions.shared.cs(62,28):
error CS0234: The type or namespace name 'Content' does not exist in the namespace 'Microsoft.Android' (are you missing an assembly reference?)
To fix this, we can prefix the namespace with `_`. We basically can
never use a `Microsoft.Android.*` namespace in `Mono.Android.dll`.
|
WearOS 2 failed with: But the tests passed, so we can ignore this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a new
internaltype inMono.Android.dll:Causes various C# compiler errors in dotnet/maui:
To fix this, we can prefix the namespace with
_. We basically can never use aMicrosoft.Android.*namespace inMono.Android.dll.