Add 2017-07-17-Span across CoreFx (Round 3) #40
Conversation
terrajobst
changed the title
| because we only broad back `TransformBlock` and `TransformBlockFinal` | ||
| back for compat. Customers should use `IncrementalHash` instead. | ||
| * `RSA` | ||
| - Remove `DecryptValue` and `EncrypValue` -- they always throw |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| `Socket` | ||
| - Nothing on `Socket` supports cancellation today; we should investigate | ||
| whether we can support cancellation in principle and add the APIs now. | ||
| * `SocketASyncEventArgs` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * `HashAlgorithm` | ||
| - We shouldn't spanify `TryTransformBlock` and `TryTransformBlockFinal` | ||
| because we only broad back `TransformBlock` and `TransformBlockFinal` | ||
| back for compat. Customers should use `IncrementalHash` instead. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| - Remove `DecryptValue` and `EncrypValue` -- they always throw | ||
| - `HashData` should be protected, not public | ||
| - The methods `Encrypt`, `Decrypt`, `HashData`, `SignData`, `SignHash` | ||
| should follow the `Try` pattern and return `bool `and return the numbers |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| of bytes written as `out` parameter | ||
| * `DSA` | ||
| - The methods `CreateSignature`, `HashData`, `SignData` should follow the | ||
| `Try` pattern and return `bool `and return the numbers of bytes written as |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| - `HashData` should be protected, not public | ||
| * `ECDsa` | ||
| - The methods `HashData`, `SignData`, `SignHash` should follow the `Try` | ||
| pattern and return `bool `and return the numbers of bytes written as `out` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| seems appealing. | ||
| * Open Issues / Other APIs | ||
| - Collections / Immutable / Metadata | ||
| - `ImmuatableArray<T>` is probably the only one that's super interesting |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@terrajobst I apologize, let me know if proofreading is getting on your nerves. It's not primarily why I'm here. =) |
|
Well, I apologize for all the typos! Speaking, listening and typing isn't my strong suit (although I've to admit even when I pay a 100% attention my typo rate is quite high) |
|
No need to apologize for typos, no harm done. I'm as guilty of them as the next person. But welcome to seeing the world through my eyes. 😝 |
| synchronously. Proposal is use `ValueTask` and a struct-based alternative | ||
| `WebSocketReceiveResult`, called `ValueWebSocketReceiveResult`. | ||
| * `HttpClient` | ||
| - Skipped for now; it's unclear how we want to handle this given this type |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@stephentoub @weshaggard @bartonjs @danmosemsft @mellinoe @ericstj