Remove src/arcade/eng/common from repos that took it

[dkurepa]

Because of #4751 (comment), there was a number of repos that took a dependency update from the VMR and accidentally added src/arcade/eng/common https://github.com/search?q=org%3Adotnet%20path%3Asrc%2Farcade%2Feng%2Fcommon%2FREADME.md&type=code. Once we have the fix rolled out, we should make sure to remove all of these

[akoeplinger]

Also one hit in the microsoft org: https://github.com/search?q=org%3Amicrosoft+path%3Asrc%2Farcade%2Feng%2Fcommon%2FREADME.md&type=code

It's possible it also happened for servicing branches right? GitHub search won't find those.

[dkurepa]

the fix for the bug that caused this has been rolled out, We should now go through the repos that merged these PRs and remove the arcade src/arcade/eng/common

[dkurepa]

Unmerged PRs which should be closed:

• [main] Update dependencies from dotnet/arcade symreader-portable#570
• [main] Update dependencies from dotnet/arcade interactive-window#261
• [main] Update dependencies from dotnet/arcade cli-lab#381
• [release/9.0.2xx] Update dependencies from dotnet/arcade workload-versions#398
• [main] Update dependencies from dotnet/arcade dnceng-shared#101
• [release/4.0] Update dependencies from dotnet/arcade machinelearning#7422

PRs to remove src/arcade/eng/common:

• Delete src/arcade/eng/common directory metadata-tools#317

• [release/8.0.1xx] Delete src/arcade/eng/common directory installer#20449

• [release/8.0.1xx] Delete src/arcade/eng/common directory sdk#49053

• [release/9.0.1xx] Delete src/arcade/eng/common directory templating#9049

• [8.0] Delete src/arcade directory aspnetcore#61994

• [release/9.0.3xx] Delete src/arcade/eng/common directory workload-versions#418

• https://github.com/microsoft/winforms-designer/pull/6404

• Delete wrong src/arcade folder install-scripts#607

• Delete src/arcade/eng/common directory windowsdesktop#5098

• Delete src/arcade/eng/common directory extensions-samples#746

• [8.0] Delete src/arcade/eng/common directory arcade-validation#4990

• [9.0] Delete src/arcade/eng/common directory arcade-validation#4989

• Delete src/arcade/eng/common directory wpf#10860

• [feature/10.0] Update dependencies from dotnet/dotnet dotnet-monitor#8258

• Delete src/arcade/eng/common directory xharness#1417

• Delete src/arcade/eng/common directory efcore#36102

• https://github.com/dotnet/try/tree/main/src/arcade/eng/common

  • PR: Delete src/arcade/eng/common directory try#1272

• https://github.com/dotnet/fsharp/tree/main/src/arcade/eng/common

  • PR: [main] Update dependencies from dotnet/arcade fsharp#18559

• https://github.com/dotnet/wcf/tree/main/src/arcade/eng/common

  • PR: Fix pipeline build wcf#5777

• https://github.com/dotnet/macios/tree/main/src/arcade/eng/common

  • PR: [main] Update dependencies from dotnet/arcade macios#22805

• https://github.com/dotnet/xharness/tree/main/src/arcade/eng/common

  • PR: [main] Update dependencies from dotnet/arcade xharness#1412

• https://github.com/dotnet/hotreload-utils/tree/main/src/arcade/eng/common

  • PR: [main] Update dependencies from dotnet/arcade hotreload-utils#558

• https://github.com/dotnet/arcade-validation/tree/main/src/arcade/eng/common

  • PR: Delete src/arcade/eng/common directory arcade-validation#4984

• https://github.com/dotnet/binaryen/tree/main/src/arcade/eng/common

  • PR: [dotnet/main] Update dependencies from dotnet/arcade binaryen#212

• https://github.com/dotnet/templating/tree/main/src/arcade/eng/common

  • PR: Delete src/arcade/eng/common directory templating#9040

• https://dev.azure.com/dnceng/internal/_git/dotnet-diagnostictests?path=/src/arcade/eng/common&version=GBmain

  • PR: https://dev.azure.com/dnceng/internal/_git/dotnet-diagnostictests/pullrequest/50078?path=%2Feng%2FVersion.Details.xml

[akoeplinger]

One more which is on AzDO only: https://dev.azure.com/dnceng/internal/_git/dotnet-diagnostictests?path=/src/arcade/eng/common&version=GBmain

[akoeplinger]

So turns out just deleting src/arcade might not be enough, we also need to replace eng/common with a good copy because when the wrong folder was added git recognized some of the files as "moved" there in some repos like wcf.

[akoeplinger]

Found an easier way: trigger the arcade subscription, the new PR will put the files back into eng/common and then you can just delete src/arcade in the PR.