Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Feb 14, 2024

am11 added 2 commits February 14, 2024 18:34
>   /__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.arcade.sdk/9.0.0-beta.24106.2/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/__w/1/s/artifacts/sb/src/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj]
mmitche
mmitche previously approved these changes Feb 14, 2024
@ViktorHofer ViktorHofer merged commit 89008f3 into dotnet:main Feb 15, 2024
mikem8361 pushed a commit to dotnet/diagnostics that referenced this pull request Feb 21, 2024
<IsShipping>false</IsShipping>
<EnableNETAnalyzers>true</EnableNETAnalyzers>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
<RepositoryUrl>https://github.com/dotnet/arcade</RepositoryUrl>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmat I wonder what changed that made this necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error looked like this (for multiple projects):

/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.arcade.sdk/9.0.0-beta.24106.2/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/__w/1/s/artifacts/sb/src/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dotnet/sourcelink@0647320 caused this but am not 100% sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it's actually a different change. See discussion in dotnet/runtime#98476 (comment).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer See #14487 (comment)

I think the issue is that the inner clone isn't propagating the remotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants