Update microbuild to use PME service connection #15797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
approved these changes
Apr 30, 2025
Contributor
|
why is this a draft @hoyosjs❔ |
Member
Author
|
We should hold off merging until tactics discuss this - the impact is pretty heavy handed for end customer workflows and potentially breaks many workflows. At the very least it needs wide communication since it could end up with many pipelines created. |
Contributor
|
@mmitche ^^ |
Member
|
Does this have the right value for the DevDiv project? |
hoyosjs
commented
Jun 12, 2025
| signType: $(_SignType) | ||
| zipSources: false | ||
| feedSource: https://dnceng.pkgs.visualstudio.com/_packaging/MicroBuildToolset/nuget/v3/index.json | ||
| ${{ if and(eq(parameters.enableMicrobuildForMacAndLinux, 'true'), ne(variables['Agent.Os'], 'Windows_NT')) }}: |
Member
Author
There was a problem hiding this comment.
do we always use the dnceng feed?
hoyosjs
commented
Jun 12, 2025
hoyosjs
commented
Jun 12, 2025
Member
Author
|
@mmitche - fixed up |
Member
|
At least in dnceng, this does not cause friction right now. Havne't tried devdiv yet. |
Member
Author
|
@mmitche - can you please approve? |
mmitche
approved these changes
Jun 18, 2025
Member
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/arcade/actions/runs/15742061669 |
Contributor
|
@mmitche backporting to "release/9.0" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Update microbuild to use PME service connection
Using index info to reconstruct a base tree...
A eng/common/core-templates/steps/install-microbuild.yml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): eng/common/core-templates/steps/install-microbuild.yml deleted in HEAD and modified in Update microbuild to use PME service connection. Version Update microbuild to use PME service connection of eng/common/core-templates/steps/install-microbuild.yml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update microbuild to use PME service connection
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
mmitche
pushed a commit
to mmitche/arcade
that referenced
this pull request
Jun 20, 2025
mmitche
pushed a commit
to mmitche/arcade
that referenced
this pull request
Jun 20, 2025
mmitche
added a commit
that referenced
this pull request
Jun 20, 2025
#15920) Co-authored-by: Juan Hoyos <[email protected]>
hoyosjs
added a commit
that referenced
this pull request
Jun 26, 2025
#15921) Co-authored-by: Juan Hoyos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check: