Work around Microsoft/msbuild#3345#1683
Merged
natemcmaster merged 1 commit intodotnet:masterfrom Jan 7, 2019
Merged
Conversation
`helix.proj` is built with the target `Test`, but does important work in `Wait`. Since that target was hooked to `Test` by an `AfterTargets`, it hit a bug in MSBuild that failed `AfterTargets` targets don't fail a build that builds the target they hook. Restructure the targets (transparently to callers) to avoid that situation and observe failures in `Wait`.
MattGal
approved these changes
Jan 3, 2019
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
LGTM. I assume the worked-around thing will eventually get fixed?
Member
Author
|
It's definitely a bug. When we looked at it last it was not very clear what the fix was so it might take a while to bubble to the top of our stack. When it is fixed, this target order will keep working, so no special need to revert this at that time. |
HaoK
approved these changes
Jan 3, 2019
joperezr
pushed a commit
to joperezr/arcade
that referenced
this pull request
Jan 11, 2019
…et#1667)" (dotnet#1683) This reverts commit 5b80a24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helix.projis built with the targetTest, but does important workin
Wait. Since that target was hooked toTestby anAfterTargets,it hit a bug in MSBuild that failed
AfterTargetstargets don't fail abuild that builds the target they hook.
Restructure the targets (transparently to callers) to avoid that
situation and observe failures in
Wait.