Fixed dapr sidecar resolution when app in container #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidfowl
commented
Dec 6, 2023
davidfowl
commented
- When the app is in a container we need to tell it to communicate over the container host instead of local host. Not all SDKs support this new env variable, but we set it anyways (.NET works).
- When the app is in a container we need to tell it to communicate over the container host instead of local host. Not all SDKs support this new env variable, but we set it anyways (.NET works).
ghost
added
the
area-app-model
davidfowl
commented
Dec 6, 2023
| /// <summary> | ||
| /// Helpers to resolve host names when running in a containers. | ||
| /// </summary> | ||
| public class HostNameResolver |
Member
Author
There was a problem hiding this comment.
This could be shared source, made it public for now.
philliphoff
approved these changes
Dec 6, 2023
JamesNK
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.