Fix heartbeat monitoring on Windows - replace deprecated wmic with PowerShell #13555

Copilot · 2025-12-14T15:01:22Z

Description

The heartbeat monitoring tool showed CPU: N/A and DCP: none on Windows because wmic (Windows Management Instrumentation Command-line) is deprecated and not functioning properly on GitHub Actions runners. Replaced all wmic commands with modern PowerShell cmdlets using CIM (Common Information Model) API.

Changes

CPU detection: Use Get-CimInstance Win32_Processor with Measure-Object -Average to handle multi-processor systems correctly
Memory detection: Use Get-CimInstance Win32_OperatingSystem to get FreePhysicalMemory and TotalVisibleMemorySize
DCP process detection: Use Get-Process -Name 'dcp*' with pipe-delimited output for robust parsing (avoids CSV quoting issues)

Key Improvements

Multi-processor support: CPU load is averaged across all processors using Measure-Object -Average
Robust parsing: DCP process info uses pipe delimiter (|) instead of CSV to avoid issues with commas/quotes in process names
Modern API: CIM cmdlets work reliably on all Windows versions (Windows Server 2016+, Windows 10+)
Efficient queries: Direct filtering with -Name parameter and -ErrorAction SilentlyContinue for error handling

Before:

HEARTBEAT | CPU: N/A | Mem: 0 MB (process) | ... | DCP: none

After (expected):

HEARTBEAT | CPU: 15.2% | Mem: 8.5/16.0 GB (53%) | ... | DCP: 2 procs (150MB) [dcp(1234):75MB, ...]

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
- No
Does the change make any security assumptions or guarantees?
- Yes
- No
Does the change require an update in our Aspire docs?
- Yes
- No

Original prompt

The heartbeat we added to the run-tests github workflow doesnt work on windows. Ir shows rhis

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: davidfowl <[email protected]>

…ady handles trimming Co-authored-by: davidfowl <[email protected]>

Co-authored-by: davidfowl <[email protected]>

github-actions · 2025-12-14T17:52:02Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13555

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13555"

afscrome · 2025-12-14T20:34:46Z

WNIC is deprecated - may want to use another command instead https://techcommunity.microsoft.com/blog/windows-itpro-blog/wmi-command-line-wmic-utility-deprecation-next-steps/4039242

davidfowl · 2025-12-14T22:04:20Z

@copilot It's still

Co-authored-by: davidfowl <[email protected]>

Copilot · 2025-12-14T22:09:38Z

@copilot It's still

Fixed in 1ac9379. The issue was that wmic is deprecated and not working properly on Windows. Replaced with PowerShell cmdlets:

CPU: Get-CimInstance Win32_Processor
Memory: Get-CimInstance Win32_OperatingSystem
DCP processes: Get-Process with CSV output

…rsing Co-authored-by: davidfowl <[email protected]>

Co-authored-by: davidfowl <[email protected]>

radical · 2025-12-15T00:13:01Z

Copilot

Pull request overview

This PR fixes heartbeat monitoring on Windows by replacing deprecated wmic commands with modern PowerShell cmdlets using the CIM (Common Information Model) API. The changes address issues where CPU usage showed "N/A" and DCP process detection showed "none" on Windows GitHub Actions runners.

Key changes:

Replace wmic cpu get loadpercentage with Get-CimInstance Win32_Processor and average LoadPercentage across processors
Replace wmic OS get FreePhysicalMemory,TotalVisibleMemorySize with Get-CimInstance Win32_OperatingSystem
Replace wmic process with Get-Process -Name 'dcp*' using pipe-delimited output for robust parsing

Copilot · 2025-12-15T00:47:43Z

tools/scripts/Heartbeat.cs

+                long.TryParse(parts[0].Trim(), out var freeKb) && 
+                long.TryParse(parts[1].Trim(), out var totalKb))


The long.TryParse calls should specify NumberStyles.Integer and CultureInfo.InvariantCulture to ensure consistent parsing across different system locales. This prevents potential parsing failures on systems with non-English regional settings. Change to long.TryParse(parts[0].Trim(), NumberStyles.Integer, CultureInfo.InvariantCulture, out var freeKb) and long.TryParse(parts[1].Trim(), NumberStyles.Integer, CultureInfo.InvariantCulture, out var totalKb) for consistency with other parsing operations in this file.

Suggested change

long.TryParse(parts[0].Trim(), out var freeKb) &&

long.TryParse(parts[1].Trim(), out var totalKb))

long.TryParse(parts[0].Trim(), NumberStyles.Integer, CultureInfo.InvariantCulture, out var freeKb) &&

long.TryParse(parts[1].Trim(), NumberStyles.Integer, CultureInfo.InvariantCulture, out var totalKb))

Copilot · 2025-12-15T00:47:43Z

tools/scripts/Heartbeat.cs

+                    int.TryParse(parts[1], out var pid) && 
+                    long.TryParse(parts[2], out var workingSet))


The int.TryParse and long.TryParse calls should specify NumberStyles and CultureInfo.InvariantCulture to ensure consistent parsing across different system locales. This prevents potential parsing failures on systems with non-English regional settings. Change to int.TryParse(parts[1], NumberStyles.Integer, CultureInfo.InvariantCulture, out var pid) and long.TryParse(parts[2], NumberStyles.Integer, CultureInfo.InvariantCulture, out var workingSet) for consistency with other parsing operations in this file.

Suggested change

int.TryParse(parts[1], out var pid) &&

long.TryParse(parts[2], out var workingSet))

int.TryParse(parts[1], NumberStyles.Integer, CultureInfo.InvariantCulture, out var pid) &&

long.TryParse(parts[2], NumberStyles.Integer, CultureInfo.InvariantCulture, out var workingSet))

Copilot · 2025-12-15T00:47:43Z

tools/scripts/Heartbeat.cs

-            var match = System.Text.RegularExpressions.Regex.Match(output, @"LoadPercentage=(\d+)");
-            if (match.Success)
+            var trimmed = output.Trim();
+            if (double.TryParse(trimmed, out var loadPercentage))


The double.TryParse call should specify CultureInfo.InvariantCulture to ensure consistent parsing across different system locales. PowerShell may output decimal numbers with culture-specific separators (e.g., comma vs. period), which could cause parsing to fail on systems with non-English locales. Change to double.TryParse(trimmed, NumberStyles.Float, CultureInfo.InvariantCulture, out var loadPercentage) for consistency with other parsing operations in this file (see lines 130, 194, 222).

Suggested change

if (double.TryParse(trimmed, out var loadPercentage))

if (double.TryParse(trimmed, NumberStyles.Float, CultureInfo.InvariantCulture, out var loadPercentage))

Initial plan

428f185

Copilot AI assigned Copilot and davidfowl Dec 14, 2025

Copilot started work on behalf of davidfowl December 14, 2025 15:01 View session

Copilot AI and others added 4 commits December 14, 2025 15:09

Fix heartbeat monitoring on Windows for CPU and DCP detection

47d30e6

Co-authored-by: davidfowl <[email protected]>

Remove redundant Trim calls since StringSplitOptions.TrimEntries alre…

e66a552

…ady handles trimming Co-authored-by: davidfowl <[email protected]>

Remove redundant IsNullOrWhiteSpace check for CSV parsing

f1024e6

Co-authored-by: davidfowl <[email protected]>

Remove redundant dcp name check since wmic query already filters by name

fcec27b

Co-authored-by: davidfowl <[email protected]>

Copilot AI changed the title ~~[WIP] Fix heartbeat issue in run-tests workflow for Windows~~ Fix heartbeat monitoring on Windows - handle wmic output formatting Dec 14, 2025

Copilot AI requested a review from davidfowl December 14, 2025 15:17

Copilot finished work on behalf of davidfowl December 14, 2025 15:17

Copilot started work on behalf of davidfowl December 14, 2025 22:04 View session

Replace wmic with PowerShell commands for Windows compatibility

1ac9379

Co-authored-by: davidfowl <[email protected]>

Copilot AI and others added 2 commits December 14, 2025 22:12

Improve PowerShell commands for multi-processor CPU and robust CSV pa…

dd4c55a

…rsing Co-authored-by: davidfowl <[email protected]>

Optimize PowerShell commands for better performance

14692f7

Co-authored-by: davidfowl <[email protected]>

Copilot AI changed the title ~~Fix heartbeat monitoring on Windows - handle wmic output formatting~~ Fix heartbeat monitoring on Windows - replace deprecated wmic with PowerShell Dec 14, 2025

Copilot finished work on behalf of davidfowl December 14, 2025 22:16

radical marked this pull request as ready for review December 15, 2025 00:37

Copilot AI review requested due to automatic review settings December 15, 2025 00:37

Copilot started reviewing on behalf of radical December 15, 2025 00:38 View session

radical approved these changes Dec 15, 2025

View reviewed changes

radical merged commit 54e0a00 into main Dec 15, 2025
565 of 569 checks passed

radical deleted the copilot/fix-heartbeat-windows-issue branch December 15, 2025 00:38

dotnet-policy-service bot added this to the 13.2 milestone Dec 15, 2025

Copilot AI reviewed Dec 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix heartbeat monitoring on Windows - replace deprecated wmic with PowerShell #13555

Fix heartbeat monitoring on Windows - replace deprecated wmic with PowerShell #13555

Uh oh!

Copilot AI commented Dec 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 14, 2025 •

edited

Loading

Uh oh!

afscrome commented Dec 14, 2025

Uh oh!

davidfowl commented Dec 14, 2025

Uh oh!

Copilot AI commented Dec 14, 2025

Uh oh!

radical commented Dec 15, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 15, 2025

Uh oh!

Copilot AI Dec 15, 2025

Uh oh!

Copilot AI Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		long.TryParse(parts[0].Trim(), out var freeKb) &&
		long.TryParse(parts[1].Trim(), out var totalKb))

		int.TryParse(parts[1], out var pid) &&
		long.TryParse(parts[2], out var workingSet))

	if (double.TryParse(trimmed, out var loadPercentage))
	if (double.TryParse(trimmed, NumberStyles.Float, CultureInfo.InvariantCulture, out var loadPercentage))

Fix heartbeat monitoring on Windows - replace deprecated wmic with PowerShell #13555

Fix heartbeat monitoring on Windows - replace deprecated wmic with PowerShell #13555

Uh oh!

Conversation

Copilot AI commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Key Improvements

Checklist

Uh oh!

github-actions bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

afscrome commented Dec 14, 2025

Uh oh!

davidfowl commented Dec 14, 2025

Uh oh!

Copilot AI commented Dec 14, 2025

Uh oh!

radical commented Dec 15, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Dec 14, 2025 •

edited

Loading

github-actions bot commented Dec 14, 2025 •

edited

Loading