Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Aspire.Hosting/ApplicationModel/ResourceUrlAnnotation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ public sealed class ResourceUrlAnnotation : IResourceAnnotation
public EndpointReference? Endpoint { get; init; }

/// <summary>
/// The display order the URL. Higher values mean sort higher in the list.
/// The display order of the URL. Higher values mean sort higher in the list.
/// </summary>
public int? DisplayOrder;
public int? DisplayOrder { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it would be a breaking change. Either we fix it now or never change it.

Do you have suggestions to mitigate? We could put an issue in the CT repo to let them know and document that MCP inspector requires a certain version of Aspire

cc @aaronpowell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to break it I think we should wait for a major version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. If 13.2 is the next release then this should wait.

Copy link
Member

@JamesNK JamesNK Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have time before this releases, we can help smooth out breaking change by removing usage in community toolkit - CommunityToolkit/Aspire#1088. Then re-add it once CT upgrades to vnext major.


/// <summary>
/// Locations where this URL should be shown on the dashboard. Defaults to <see cref="UrlDisplayLocation.SummaryAndDetails"/>.
Expand Down
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/api/Aspire.Hosting.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3157,7 +3157,7 @@ public ResourceStoppedEvent(IResource resource, System.IServiceProvider services
[System.Diagnostics.DebuggerDisplay("Url = {Url}, DisplayText = {DisplayText}")]
public sealed partial class ResourceUrlAnnotation : IResourceAnnotation
{
public int? DisplayOrder;
public int? DisplayOrder { get { throw null; } set { } }
public UrlDisplayLocation DisplayLocation { get { throw null; } set { } }

public string? DisplayText { get { throw null; } set { } }
Expand Down