Automate refreshing manifests with GitHub Action #9503
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Refresh Manifests | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 16 * * *' # 8am PST (16:00 UTC) - same schedule as API review | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| generate-and-pr: | ||
| runs-on: windows-latest # Using Windows because the script uses PowerShell and build.cmd | ||
| if: ${{ github.repository_owner == 'dotnet' }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: Setup .NET SDK | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| global-json-file: global.json | ||
|
|
||
| - name: Run RefreshManifests Script | ||
| shell: pwsh | ||
| run: | | ||
| ./eng/refreshManifests.ps1 | ||
|
|
||
| - name: Create or update pull request | ||
| uses: dotnet/actions-create-pull-request@e8d799aa1f8b17f324f9513832811b0a62f1e0b1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| branch: update-manifests | ||
| base: main | ||
| labels: | | ||
| area-app-model | ||
| area-engineering-systems | ||
| title: "[Automated] Update Manifests" | ||
| body: "Auto-generated update to refresh the manifests. This PR will be updated automatically if new changes are detected." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,2 +1,47 @@ | ||||||
| #!/usr/bin/env pwsh | ||||||
|
|
||||||
| # Get the script directory | ||||||
| $scriptDir = $PSScriptRoot | ||||||
| $repoRoot = Split-Path -Parent $scriptDir | ||||||
|
|
||||||
| # Determine which build script to use based on OS | ||||||
| if ($IsWindows -or $env:OS -eq "Windows_NT") { | ||||||
| & "$repoRoot/build.cmd" | ||||||
| } else { | ||||||
| & "$repoRoot/build.sh" | ||||||
| } | ||||||
|
|
||||||
| # Find all AppHost projects in the playground directory | ||||||
| $playgroundDir = Join-Path -Path $repoRoot -ChildPath "playground" | ||||||
|
|
||||||
| if (Test-Path $playgroundDir) { | ||||||
| Get-ChildItem -Path $playgroundDir -Filter "*AppHost.csproj" -Recurse | ForEach-Object { | ||||||
| # Check if the project has a launchSettings.json file with a generate-manifest profile | ||||||
| $projectDir = Split-Path -Parent $_.FullName | ||||||
| $launchSettingsPath = Join-Path -Path $projectDir -ChildPath "Properties" -AdditionalChildPath "launchSettings.json" | ||||||
|
There was a problem hiding this comment. The Join-Path cmdlet does not support an '-AdditionalChildPath' parameter. Consider using nested Join-Path calls or joining 'Properties/launchSettings.json' as a single string to avoid runtime errors.
Suggested change
Copilot uses AI. Check for mistakes. There was a problem hiding this comment. @copilot can you run the script to see if it works?
|
||||||
| $hasManifestProfile = $false | ||||||
|
|
||||||
| if (Test-Path $launchSettingsPath) { | ||||||
| try { | ||||||
| $launchSettings = Get-Content -Raw -Path $launchSettingsPath | ConvertFrom-Json | ||||||
| if ($launchSettings.profiles -and $launchSettings.profiles.'generate-manifest') { | ||||||
| $hasManifestProfile = $true | ||||||
| } | ||||||
| } | ||||||
| catch { | ||||||
| Write-Warning "Failed to read or parse launch settings for $_" | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| if ($hasManifestProfile) { | ||||||
| Write-Host "Generating Manifest for: $_" | ||||||
| dotnet run --no-build --project $_.FullName --launch-profile generate-manifest | ||||||
| } | ||||||
| else { | ||||||
| Write-Warning "Skipping $_ - no generate-manifest profile found" | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| else { | ||||||
| Write-Error "Playground directory not found at: $playgroundDir" | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| @description('The location for the resource(s) to be deployed.') | ||
| param location string = resourceGroup().location | ||
|
|
||
| param storage2_outputs_name string | ||
|
|
||
| param principalType string | ||
|
|
||
| param principalId string | ||
|
|
||
| resource storage2 'Microsoft.Storage/storageAccounts@2024-01-01' existing = { | ||
| name: storage2_outputs_name | ||
| } | ||
|
|
||
| resource storage2_StorageBlobDataContributor 'Microsoft.Authorization/roleAssignments@2022-04-01' = { | ||
| name: guid(storage2.id, principalId, subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'ba92f5b4-2d11-453d-a403-e96b0029c9fe')) | ||
| properties: { | ||
| principalId: principalId | ||
| roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'ba92f5b4-2d11-453d-a403-e96b0029c9fe') | ||
| principalType: principalType | ||
| } | ||
| scope: storage2 | ||
| } | ||
|
|
||
| resource storage2_StorageTableDataContributor 'Microsoft.Authorization/roleAssignments@2022-04-01' = { | ||
| name: guid(storage2.id, principalId, subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '0a9a7e1f-b9d0-4cc4-a60d-0319b160aaa3')) | ||
| properties: { | ||
| principalId: principalId | ||
| roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '0a9a7e1f-b9d0-4cc4-a60d-0319b160aaa3') | ||
| principalType: principalType | ||
| } | ||
| scope: storage2 | ||
| } | ||
|
|
||
| resource storage2_StorageQueueDataContributor 'Microsoft.Authorization/roleAssignments@2022-04-01' = { | ||
| name: guid(storage2.id, principalId, subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '974c5e8b-45b9-4653-ba55-5f855dd0fb88')) | ||
| properties: { | ||
| principalId: principalId | ||
| roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '974c5e8b-45b9-4653-ba55-5f855dd0fb88') | ||
| principalType: principalType | ||
| } | ||
| scope: storage2 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| @description('The location for the resource(s) to be deployed.') | ||
| param location string = resourceGroup().location | ||
|
|
||
| resource storage2 'Microsoft.Storage/storageAccounts@2024-01-01' = { | ||
| name: take('storage2${uniqueString(resourceGroup().id)}', 24) | ||
| kind: 'StorageV2' | ||
| location: location | ||
| sku: { | ||
| name: 'Standard_GRS' | ||
| } | ||
| properties: { | ||
| accessTier: 'Hot' | ||
| allowSharedKeyAccess: false | ||
| minimumTlsVersion: 'TLS1_2' | ||
| networkAcls: { | ||
| defaultAction: 'Allow' | ||
| } | ||
| } | ||
| tags: { | ||
| 'aspire-resource-name': 'storage2' | ||
| } | ||
| } | ||
|
|
||
| resource blobs 'Microsoft.Storage/storageAccounts/blobServices@2024-01-01' = { | ||
| name: 'default' | ||
| parent: storage2 | ||
| } | ||
|
|
||
| resource foocontainer 'Microsoft.Storage/storageAccounts/blobServices/containers@2024-01-01' = { | ||
| name: 'foo-container' | ||
| parent: blobs | ||
| } | ||
|
|
||
| output blobEndpoint string = storage2.properties.primaryEndpoints.blob | ||
|
|
||
| output queueEndpoint string = storage2.properties.primaryEndpoints.queue | ||
|
|
||
| output tableEndpoint string = storage2.properties.primaryEndpoints.table | ||
|
|
||
| output name string = storage2.name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better if the manifest was updated on the PRs that made them change. Not in a separate batched PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does that look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a test (or GH action) that runs on PRs and fails when they are out of date.