Skip to content

Commit bf50999

Browse files
authored
Update duende versions to 6.0.4 (#41370)
1 parent db31993 commit bf50999

File tree

5 files changed

+23
-6
lines changed

5 files changed

+23
-6
lines changed

eng/Versions.props

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,11 @@
248248
<GrpcAuthVersion>2.45.0</GrpcAuthVersion>
249249
<GrpcNetClientVersion>2.45.0</GrpcNetClientVersion>
250250
<GrpcToolsVersion>2.45.0</GrpcToolsVersion>
251-
<DuendeIdentityServerAspNetIdentityVersion>5.2.0</DuendeIdentityServerAspNetIdentityVersion>
252-
<DuendeIdentityServerEntityFrameworkVersion>5.2.0</DuendeIdentityServerEntityFrameworkVersion>
253-
<DuendeIdentityServerVersion>5.2.0</DuendeIdentityServerVersion>
254-
<DuendeIdentityServerStorageVersion>5.2.0</DuendeIdentityServerStorageVersion>
255-
<DuendeIdentityServerEntityFrameworkStorageVersion>5.2.0</DuendeIdentityServerEntityFrameworkStorageVersion>
251+
<DuendeIdentityServerAspNetIdentityVersion>6.0.4</DuendeIdentityServerAspNetIdentityVersion>
252+
<DuendeIdentityServerEntityFrameworkVersion>6.0.4</DuendeIdentityServerEntityFrameworkVersion>
253+
<DuendeIdentityServerVersion>6.0.4</DuendeIdentityServerVersion>
254+
<DuendeIdentityServerStorageVersion>6.0.4</DuendeIdentityServerStorageVersion>
255+
<DuendeIdentityServerEntityFrameworkStorageVersion>6.0.4</DuendeIdentityServerEntityFrameworkStorageVersion>
256256
<MessagePackVersion>2.1.90</MessagePackVersion>
257257
<MicrosoftIdentityWebVersion>1.16.0</MicrosoftIdentityWebVersion>
258258
<MicrosoftIdentityWebMicrosoftGraphVersion>1.16.0</MicrosoftIdentityWebMicrosoftGraphVersion>

src/Identity/ApiAuthorization.IdentityServer/src/Authentication/IdentityServerJwtBearerOptionsConfiguration.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ internal static async Task ResolveAuthorityAndKeysAsync(MessageReceivedContext m
6161
{
6262
var store = messageReceivedContext.HttpContext.RequestServices.GetRequiredService<ISigningCredentialStore>();
6363
var credential = await store.GetSigningCredentialsAsync();
64+
#pragma warning disable 0618
6465
options.Authority = options.Authority ?? messageReceivedContext.HttpContext.GetIdentityServerIssuerUri();
66+
#pragma warning restore 0618
6567
options.TokenValidationParameters.IssuerSigningKey = credential.Key;
6668
options.TokenValidationParameters.ValidIssuer = options.Authority;
6769
}

src/Identity/ApiAuthorization.IdentityServer/src/Extensions/DefaultClientRequestParametersProvider.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ public DefaultClientRequestParametersProvider(
2525
public IDictionary<string, string> GetClientParameters(HttpContext context, string clientId)
2626
{
2727
var client = Options.Value.Clients[clientId];
28+
#pragma warning disable 0618
29+
// Deprecated in Identity Server 6.0
2830
var authority = context.GetIdentityServerIssuerUri();
31+
#pragma warning restore 0618
2932
if (!client.Properties.TryGetValue(ApplicationProfilesPropertyNames.Profile, out var type))
3033
{
3134
throw new InvalidOperationException($"Can't determine the type for the client '{clientId}'");

src/Identity/ApiAuthorization.IdentityServer/test/Authentication/LocalApiJwtBearerConfigurationTest.cs renamed to src/Identity/ApiAuthorization.IdentityServer/test/Authentication/IdentityServerJwtBearerConfigurationTest.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
// Licensed to the .NET Foundation under one or more agreements.
1+
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33

44
using System.Security.Cryptography;
55
using Duende.IdentityServer.Configuration;
6+
using Duende.IdentityServer.Services;
67
using Duende.IdentityServer.Stores;
78
using Microsoft.AspNetCore.ApiAuthorization.IdentityServer.Configuration;
89
using Microsoft.AspNetCore.Authentication;
@@ -59,12 +60,16 @@ public async Task ResolveAuthorityAndKeysAsync_SetsUpAuthorityAndKeysOnTheTokenV
5960
credentialsStore.Setup(cs => cs.GetSigningCredentialsAsync())
6061
.ReturnsAsync(new SigningCredentials(key, "RS256"));
6162

63+
var issuerName = new Mock<IIssuerNameService>();
64+
issuerName.Setup(i => i.GetCurrentAsync()).ReturnsAsync("https://localhost");
65+
6266
var context = new DefaultHttpContext();
6367
context.Request.Scheme = "https";
6468
context.Request.Host = new HostString("localhost");
6569
context.RequestServices = new ServiceCollection()
6670
.AddSingleton(new IdentityServerOptions())
6771
.AddSingleton(credentialsStore.Object)
72+
.AddSingleton(issuerName.Object)
6873
.BuildServiceProvider();
6974

7075
var options = new JwtBearerOptions();

src/Identity/ApiAuthorization.IdentityServer/test/Extensions/DefaultClientRequestParametersProviderTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// The .NET Foundation licenses this file to you under the MIT license.
33

44
using Duende.IdentityServer.Configuration;
5+
using Duende.IdentityServer.Services;
56
using Microsoft.AspNetCore.Http;
67
using Microsoft.Extensions.DependencyInjection;
78
using Microsoft.Extensions.Options;
@@ -11,6 +12,11 @@ namespace Microsoft.AspNetCore.ApiAuthorization.IdentityServer.Extensions;
1112

1213
public class DefaultClientRequestParametersProviderTests
1314
{
15+
class NameService : IIssuerNameService
16+
{
17+
public Task<string> GetCurrentAsync() => Task.FromResult("http://localhost");
18+
}
19+
1420
[Fact]
1521
public void GetClientParameters_ReturnsParametersForExistingClients()
1622
{
@@ -30,6 +36,7 @@ public void GetClientParameters_ReturnsParametersForExistingClients()
3036
context.Request.Host = new HostString("localhost");
3137
context.RequestServices = new ServiceCollection()
3238
.AddSingleton(new IdentityServerOptions())
39+
.AddSingleton<IIssuerNameService>(new NameService())
3340
.BuildServiceProvider();
3441

3542
var clientRequestParametersProvider =

0 commit comments

Comments
 (0)