Update duende versions to 6.0.4 #41370
Conversation
ghost
added
the
area-infrastructure
|
We have a 6.1 that will be released in the next week or so, FWIW. |
|
Thanks for the heads up @brockallen I'll wait to update to 6.1 then |
|
@HaoK Here's the preview if you wanted to test sooner: https://www.nuget.org/packages/Duende.IdentityServer/6.1.0-preview.3 |
| public IDictionary<string, string> GetClientParameters(HttpContext context, string clientId) | ||
| { | ||
| var client = Options.Value.Clients[clientId]; | ||
| var authority = context.GetIdentityServerIssuerUri(); | ||
| var authority = NameService.GetCurrentAsync().GetAwaiter().GetResult(); |
There was a problem hiding this comment.
This is a little gross but the old obsolete API is sync, and IIssuerNameService is async only
There was a problem hiding this comment.
Does the obsolete API still work? If so, keep calling it.
There was a problem hiding this comment.
Ok will suppress obsolete then
There was a problem hiding this comment.
At what point can we make breaking changes and make this one async? Isn't a version like 7.0 a good opportunity? Or at least add/use the async one and make the GetClientParameters obsolete.
|
Hi @brockallen. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Cool, we'll update to 6.1 for preview6 |
For #41315