-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Rename Blazor project templates #10348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would like to recommend having "WebSockets" prominently displayed somewhere for server-side mode, if not in the name itself, then in the description (if it's not already). Having this in the name would certainly help alleviate confusion with the different modes and provide a clearer description of how the state is updated in the application. At least, it would for me. 😁 It would also be great to see this used in general terminology and documentation as well, as personally, I think it's one of the coolest features to hit the .NET space in quite a while. Yes, cooler than WebAssembly as it allows you to take a more traditional (and safer?) route for those who are more risk-averse in their development strategies. |
@danroth27 @DamianEdwards @mkArtakMSFT Is this official? I will take this one but want to confirm these are the names. Should we update the description in VS as well? |
@isaac2004 Yes, these are the final template names. If you'd like to help out with the updates, that would be great, although it's a bit more work than just changing the names. ASP.NET Core hosted parameterWe need to decide on the parameter name for the Blazor WebAssembly App template to indicate that it should be ASP.NET Core hosted. I propose we go with Blazor Server App descriptionI'm also in favor of updating the description of the Blazor Server App template. Here's the current description:
Proposed new description:
Blazor WebAssembly App desriptionWe also need a new description for the Blazor WebAssembly App template that combines the descriptions of the existing templates. Here are the current template descriptions Current blazor description:
Current blazorhosted description:
Proposed new blazorwasm description;
Updated template and group identitiesWe need to decide what the group identity of the Blazor WebAssembly App template should be. We might as well also cleanup the identities for the Blazor Server App as well while we're at it: blazorserver group id: Microsoft.Web.RazorComponents -> Microsoft.Web.BlazorServer Cleanup "RazorComponents" sourceWe should probably also do the work to clean up the source to no longer refer to the old RazorComponents name. Move RazorComponentsWeb-CSharp source to -> BlazorServerWeb |
@danroth27 I assumed it was more work :). I can still start on it. |
@danroth27 I'll work on getting the resource strings updated in the WebTools resx so we can get updated localization to push back into the aspnet repo. I also just noticed that we never had the resources for the Blazor WebAssembly template, so the name and description were never localized. |
@phenning That's probably because the Blazor WebAssembly templates don't ship in VS yet - they ship out of band in a VSIX. |
@danroth27 It did have resource ids in it that were unused though, so we could have added the resources in VS earlier. In any event, I'll add it now so we can get some seed localization for it. |
@danroth27 regarding the Blazor Web Assembly template, did you want to expose the hosted option in Visual Studio via the new options panel features we are adding in 16.3? I can give guidance on the required authoring to the vs-2017.3.host.json file if you want to do that. |
@phenning Yes! Your guidance would be much appreciated. |
@phenning I am working on this issue now. When I am at the point to bring in the VS stuff, I will reach out. |
@danroth27, this is blocked because of a defect in templating. According to that defect and prelim research, you cannot exclude folders that are tied to the project/folder rename process. In order to complete the template work, I need for that exclude to hide project and folders based on a new option --hosted. |
@isaac2004 I discussed this with @seancpeters and for now, let's rename the folders for the ASP.NET Core Hosted template to always be "Client", "Server", and "Shared" without any other prefix. /cc @vijayrkn |
Do you need an ETA of when this needs to be done? I assume you want it in 3.0 RC? |
We need to get this done in the next few weeks for 3.0 Preview 8. |
@danroth27 I should have it done early this week |
Rename Blazor Templates(#10348)
@ryanbrandenburg this can be closed right? |
In-box is called "Blazor Server App" / blazorserver
OOB is called "Blazor WebAssembly App" / blazorwasm
With an option to add a hosting ASP.NET Core project
The text was updated successfully, but these errors were encountered: