Skip to content

[Helix] enable Microsoft.AspNetCore.Mvc.FunctionalTests #10423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
natemcmaster opened this issue May 21, 2019 · 3 comments · Fixed by #29028
Closed

[Helix] enable Microsoft.AspNetCore.Mvc.FunctionalTests #10423

natemcmaster opened this issue May 21, 2019 · 3 comments · Fixed by #29028
Assignees
@HaoK
Labels
affected-medium This issue impacts approximately half of our customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! severity-major This label is used by an internal tool task
Milestone
6.0-preview1

Comments

@natemcmaster
Copy link
Contributor

src/Mvc/test/Mvc.FunctionalTests/Microsoft.AspNetCore.Mvc.FunctionalTests.csproj

This test project does not work in Helix and is currently disabled because it has a dependency on the layout of the source code in this repo.

Recommendation for updating: see dotnet/extensions#1697
@natemcmaster natemcmaster added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 21, 2019
natemcmaster added a commit to natemcmaster/AspNetCore that referenced this issue May 21, 2019
@natemcmaster
Workaround dotnet#10423
2b7336c
@natemcmaster natemcmaster mentioned this issue May 21, 2019
Merged
natemcmaster added a commit to natemcmaster/AspNetCore that referenced this issue May 21, 2019
@natemcmaster
fixup! Workaround dotnet#10423
caeabdf
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview7 milestone May 23, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview9, 3.1.0 Jul 17, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.1.0, Infrastructure, Backlog Aug 27, 2019
@javiercn javiercn added affected-medium This issue impacts approximately half of our customers severity-major This label is used by an internal tool labels Nov 6, 2020 — with ASP.NET Core Issue Ranking
@HaoK HaoK self-assigned this Jan 8, 2021
@HaoK HaoK modified the milestones: Backlog, 6.0-preview1 Jan 8, 2021
@HaoK HaoK added the Working label Jan 8, 2021
@HaoK HaoK linked a pull request Jan 8, 2021 that will close this issue
Unify publish/test mvc.testing functionality + switch to helix for mvc functional tests #29028
Merged
@HaoK HaoK mentioned this issue Jan 8, 2021
Merged
@HaoK
Copy link
Member

HaoK commented Jan 13, 2021

Skipped tests on helix:
Link/Script in HtmlGenerationTest.WebPagesData

HtmlGenerationWebSite_GeneratesExpectedResultsNotReadyForHelix
HtmlGenerationWebSite_GenerateEncodedResultsNotReadyForHelix
TagHelpersTest.CanRenderViewsWithTagHelpersNotReadyForHelix

Also revert:

        public async Task CompilationFailuresFromViewImportsAreListed()
            var expectedCompilationContent = "public class Views_ErrorFromViewImports_Index : "

@ghost ghost added Done This issue has been fixed and removed Working labels Jan 19, 2021
@HaoK HaoK reopened this Jan 19, 2021
@HaoK
Copy link
Member

HaoK commented Jan 19, 2021

Keeping this bug open until skipped tests are reenabled

@HaoK HaoK added Working and removed Done This issue has been fixed labels Jan 19, 2021
@HaoK
Copy link
Member

HaoK commented Jan 25, 2021

Test failures tracked #29597

@HaoK HaoK closed this as completed Jan 25, 2021
@ghost ghost added Done This issue has been fixed and removed Working labels Jan 25, 2021
@HaoK HaoK added the ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! label Jan 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
affected-medium This issue impacts approximately half of our customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! severity-major This label is used by an internal tool task
Projects
None yet
Milestone
6.0-preview1
5 participants
@pranavkm @natemcmaster @HaoK @javiercn @mkArtakMSFT