Skip to content

[Test utils] create more granular skip conditions for Linux #10428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
natemcmaster opened this issue May 21, 2019 · 1 comment
Closed

[Test utils] create more granular skip conditions for Linux #10428

natemcmaster opened this issue May 21, 2019 · 1 comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@natemcmaster
Copy link
Contributor

As the matrix of Linux test platforms expands, is has become necessary to skip tests on specific versions of Linux which do not meet system requirements for certain features of ASP.NET Core.

For example, HTTP/2 does not work on Debian 8 because the version of OpenSSL it uses is too old.

Desired usage:

[ConditionalFact]
[OSSkipCondition(KnownRuntimeIdentifiers.Debian8)]
natemcmaster added a commit to natemcmaster/AspNetCore that referenced this issue May 21, 2019
@natemcmaster
Workaround dotnet#10428
c6e29a6
@natemcmaster natemcmaster added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 21, 2019
@natemcmaster natemcmaster mentioned this issue May 21, 2019
Merged
@JunTaoLuo JunTaoLuo self-assigned this Jun 17, 2019
@dougbu
Copy link
Contributor

dougbu commented Mar 13, 2020

We're actually moving away from granular skips and toward quarantining tests across the board. We also seem to have the skip conditions we need when tests don't run on one or more platforms.

@dougbu dougbu closed this as completed Mar 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pranavkm @JunTaoLuo @natemcmaster @dougbu