Skip to content

Directive completion is flaking out when you type the entire directive and then delete #10940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rynowak opened this issue Jun 6, 2019 · 6 comments
Closed

Directive completion is flaking out when you type the entire directive and then delete #10940

rynowak opened this issue Jun 6, 2019 · 6 comments
Assignees
@NTaylorMullen
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug.
Milestone
3.1.0

Comments

@rynowak
Copy link
Member

rynowak commented Jun 6, 2019

On latest d16.2

example

It looks like completion switches the C# once you type (but don't commit) the directive name.
@rynowak
Copy link
Member Author

rynowak commented Jun 6, 2019

/cc @NTaylorMullen

@NTaylorMullen NTaylorMullen changed the title Directive completion is flaking out when you type the entire directive Directive completion is flaking out when you type the entire directive and then delete Jun 6, 2019
@NTaylorMullen
Copy link

Interesting, I'm not seeing how we can control this other than from listening to TextBuffer change events and manually dismissing completions on specific deletes. I dug through this a little bit and it seems like a completion issue. @AmadeusW any insight?

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 6, 2019
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Jun 11, 2019
@mkArtakMSFT
Copy link
Member

@NTaylorMullen please follow up on this, let's see how much we can influence here to get this fixed.

@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview8 milestone Jun 11, 2019
@AmadeusW
Copy link

@NTaylorMullen what did you learn during your investigation? Who invokes new completion after typing "inject"?
It seems that there a change in the buffer graph, WebTools dismisses completion and triggers a new one. Is there a way for WebTools to differentiate between cases when completion needs to be dismissed, and when it does not need to be dismissed?

@NTaylorMullen
Copy link

Who invokes new completion after typing "inject"?

Got to the point of seeing a new completion session start and realized it wasn't us so it was out of our control.

It seems that there a change in the buffer graph, WebTools dismisses completion and triggers a new one. Is there a way for WebTools to differentiate between cases when completion needs to be dismissed, and when it does not need to be dismissed?

I see. WebTools has a heuristic to try and guess when to dismiss/re-invoke completion. We might be able to influence this.

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview8, 3.1.0 Jun 25, 2019
@NTaylorMullen NTaylorMullen mentioned this issue Jul 3, 2019
Closed
@mkArtakMSFT
Copy link
Member

Closing this as fixed.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug.
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
6 participants
@Eilon @rynowak @ajaybhargavb @AmadeusW @NTaylorMullen @mkArtakMSFT