Skip to content

Typing @inject followed by a space completes to @injectInjectAttribute #11859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danroth27 opened this issue Jul 3, 2019 · 7 comments
Closed
Assignees
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed

Comments

@danroth27
Copy link
Member

Typing @Inject followed by a space completes to @injectInjectAttribute.

QN98rH5un7

@mkArtakMSFT mkArtakMSFT added area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. labels Jul 3, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview9 milestone Jul 3, 2019
@NTaylorMullen
Copy link

Seems like a variant of #10940

@mkArtakMSFT mkArtakMSFT added the External This is an issue in a component not contained in this repository. It is open for tracking purposes. label Jul 12, 2019
@ajaybhargavb
Copy link
Contributor

@NTaylorMullen, seeing as how this is related to #10940, is this something WTE should handle or is the fix going to be on our side?

@NTaylorMullen
Copy link

@NTaylorMullen, seeing as how this is related to #10940, is this something WTE should handle or is the fix going to be on our side?

It could be either, we'll have to investigate more. If we end up marking the span right after @inject| as C# then it'll be our issue, otherwise it'll be WTEs

@ajaybhargavb
Copy link
Contributor

I investigated this. Looks like we add a marker token at the end of @inject| to provide CSharp intellisense for the upcoming token. We fix this by only adding the marker token if there is whitespace after @inject

@rynowak
Copy link
Member

rynowak commented Aug 9, 2019

Is this just @inject or all directives?

@ajaybhargavb
Copy link
Contributor

@inject was just an example. The fix is for all extensible directives.

@ajaybhargavb ajaybhargavb added Working Done This issue has been fixed and removed External This is an issue in a component not contained in this repository. It is open for tracking purposes. Working labels Aug 9, 2019
@ajaybhargavb
Copy link
Contributor

Fixed by d953ec40c30e3dbe876bd11ad03dc72350bcf03c

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

5 participants