Skip to content

Address some rough edges in service reference feature #11393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
dougbu opened this issue Jun 19, 2019 · 1 comment
Closed
3 tasks done

Address some rough edges in service reference feature #11393

dougbu opened this issue Jun 19, 2019 · 1 comment
Assignees
@dougbu
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed
Milestone
3.0.0-preview7

Comments

@dougbu
Copy link
Contributor

dougbu commented Jun 19, 2019 •
edited
Loading

  • avoid NU1704 build warnings and other client / server incompatibility issues
  • change default $(OpenApiGenerateDocuments) to false in projects using .NET Core 2.0 or earlier
  • add inputs and outputs to GenerateOpenApiDocuments target (reducing how often it runs)

See #4923 for more detail on some of the above. Conversation at #10669 (comment) also contains some details.
@dougbu dougbu self-assigned this Jun 19, 2019
@dougbu dougbu added this to the 3.0.0-preview7 milestone Jun 19, 2019
@dougbu dougbu added cost: XS area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jun 19, 2019
dougbu added a commit that referenced this issue Jun 27, 2019
@dougbu
Address some rough edges in service reference feature
05a44fe 
- #11393
- avoid NU1702 warnings
- move defaults for `$(OpenApiGenerateDocuments)` and `$(OpenApiGenerateDocumentsOnBuild)` later, into .targets
  - do not generate documents for .NET Core 2.0 and earlier TFMs (feature is not supported there)
- add `Inputs` and `Outputs` to the `GenerateOpenApiDocuments` target, reducing redundant builds

nit: correct Microsoft.Extensions.ApiDescription.Server package version when building locally
@dougbu dougbu mentioned this issue Jun 27, 2019
Merged
dougbu added a commit that referenced this issue Jun 27, 2019
@dougbu
Address some rough edges in service reference feature
4e4ccdd 
- #11393
- avoid NU1702 warnings
- move defaults for `$(OpenApiGenerateDocuments)` and `$(OpenApiGenerateDocumentsOnBuild)` later, into .targets
  - do not generate documents for .NET Core 2.0 and earlier TFMs (feature is not supported there)
- add `Inputs` and `Outputs` to the `GenerateOpenApiDocuments` target, reducing redundant builds

nit: correct Microsoft.Extensions.ApiDescription.Server package version when building locally
@dougbu
Copy link
Contributor Author

dougbu commented Jun 27, 2019

4e4ccdd

@dougbu dougbu closed this as completed Jun 27, 2019
@dougbu dougbu added Done This issue has been fixed and removed Working labels Jun 27, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview7
Development

No branches or pull requests
1 participant
@dougbu