-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Build blazor.*.js in CI; don't commit the artifacts #11592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
SignalR has been doing this since the beginning. If you need any help or guidance you can ask us or take a look at our npm builds. https://github.com/aspnet/AspNetCore/tree/master/src/SignalR/clients/ts |
This has been completed in #12145 |
We can't actually do this given source build requirements. Though we have nodejs and yarn, we don't have the dependencies such as typescript available in source build and won't be able to compile our ts source into js artifacts. This is going to be tricky to resolve given our source build commitments. |
We need to keep pushing on this somehow (post 3.0 OK). The current state us functional (we can make progress) but unacceptable for the team's productivity (JS changes can never be merged automatically and require manual intervention). |
Related #43715 |
Blocked on #37398 |
Done by #53154 |
At some point in the recent past, we started including
blazor.*.js
in source control. This was intended as a way of avoiding the Node dependency in some CI cases. However, it turns out that:blazor.*.js
artifacts causes a merge conflict for every other such commit, even if they were only touching completely unrelated files. Some work items have been queued up for days due to this.The build team has agreed to support us with figuring out how to make this change, though @dougbu is asking that someone from the Blazor crew actually do it.
The text was updated successfully, but these errors were encountered: