Skip to content

UseReactDevelopmentServer with UseSpa keeps console open. #11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
solvingproblemswithtechnology opened this issue Jun 26, 2019 · 4 comments · Fixed by #17883
Closed

UseReactDevelopmentServer with UseSpa keeps console open. #11597

solvingproblemswithtechnology opened this issue Jun 26, 2019 · 4 comments · Fixed by #17883
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-spa ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! help wanted Up for grabs. We would accept a PR to help resolve this issue

Comments

@solvingproblemswithtechnology

Describe the bug

When I use "UseReactDevelopmentServer", the title of the console changes to "npm" and when I stop debugging with Visual Studio, this console keeps open. This can be pretty annoying when debugging fast.

To Reproduce

Version: 2.2.300, 3.0.0-preview6

  1. Create a React app using the template (or use UseReactDevelopmentServer).
  2. Start Visual Studio debugging or use dotnet run.
  3. Stop debugging.

Expected behavior

When I stop, the console should be closed.

Additional context

Looking at the code, I don't see any code to close npm. It could use IApplicationLifetime to close the process on Shutdown, for example.

@mkArtakMSFT mkArtakMSFT added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-spa labels Jun 26, 2019
@mkArtakMSFT
Copy link
Member

Thanks for contacting us, @smartcodinghub.
Will you be interested in submitting us a PR? We'll happily consider it.

@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Jun 27, 2019
@mkArtakMSFT mkArtakMSFT added help wanted Up for grabs. We would accept a PR to help resolve this issue bug This issue describes a behavior which is not expected - a bug. PRI: 3 - Optional labels Jun 27, 2019
@solvingproblemswithtechnology
Copy link
Author

I can do it this weekend, if you can point me how to do it. (dotnet version, docs to update, etc...)

@mkArtakMSFT
Copy link
Member

Thanks @smartcodinghub. You can start by reading through our contribution guidelines at: https://github.com/aspnet/AspNetCore/blob/master/CONTRIBUTING.md

@AndriySvyryd AndriySvyryd added ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! Done This issue has been fixed labels Jan 30, 2020
@mkArtakMSFT mkArtakMSFT modified the milestones: 5.0.0, 5.0.0-preview1 Feb 1, 2020
@mkArtakMSFT
Copy link
Member

Thanks @AndriySvyryd!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-spa ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants