Skip to content

[Build] Reenable components E2E tests on the CI #11698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiercn opened this issue Jun 28, 2019 · 3 comments
Closed

[Build] Reenable components E2E tests on the CI #11698

javiercn opened this issue Jun 28, 2019 · 3 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed

Comments

@javiercn
Copy link
Member

javiercn commented Jun 28, 2019

These tests got disabled by f76be64 and further changes to the build infrastructure (likely due to 4fde84a) cause the tests to hang on the CI.

We should get to the bottom of this ASAP as it hurts our ability to deliver the product with confidence.

The change here is to replace

<SkipTests>true</SkipTests>

with

<SkipTests Condition="'$(SeleniumE2ETestsSupported)' != 'true'">true</SkipTests>                                                                                                                                                                               

on .\src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj

and figure out why the component tests don't finish, as they finish on local builds.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 28, 2019
@mkArtakMSFT
Copy link
Contributor

@JunTaoLuo can you please handle this as soon as possible, as this has been a pain point for us.

@mkArtakMSFT mkArtakMSFT added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework PRI: 0 - Critical and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jul 1, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview8 milestone Jul 1, 2019
@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Jul 1, 2019

This will require expertise from the product area. Will you be able to help answer questions @javiercn when I investigate? I'm not sure if I can prioritize this above source build work in the short term though.

@dougbu
Copy link
Contributor

dougbu commented Aug 3, 2019

Many thanks @rynowak

@JunTaoLuo JunTaoLuo removed their assignment Aug 5, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

6 participants