Skip to content

Attempt to re-enable components E2E tests #12790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2019
Merged

Attempt to re-enable components E2E tests #12790

merged 1 commit into from
Aug 3, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Aug 1, 2019

No description provided.

SteveSandersonMS
SteveSandersonMS approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last!

Note that @javiercn discovered that currently the E2E reconnection tests are all broken due to the recent change for "graceful disconnect". @javiercn, do you have a plan for fixing them - is that already underway? Update: I see he already posted about this at #12788

@rynowak
Copy link
Member Author

rynowak commented Aug 1, 2019

At last!

We can celebrate once this gets merged 😁

@rynowak
Copy link
Member Author

rynowak commented Aug 1, 2019

OK, it looks like this is going to hit a timeout.

@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Aug 1, 2019
@rynowak rynowak force-pushed the rynowak/unskip-my-heart branch from 55e6aca to 85e0d67 Compare August 2, 2019 21:19
@rynowak
Copy link
Member Author

rynowak commented Aug 2, 2019

Trying this again with a few more test fixes and my change to have tests fail faster. If this doesn't pass then hopefully we can see some fireworks.

@rynowak rynowak requested a review from a team as a code owner August 3, 2019 00:51
@rynowak rynowak force-pushed the rynowak/unskip-my-heart branch 2 times, most recently from 484b274 to 7b00e0c Compare August 3, 2019 02:50
@rynowak
Copy link
Member Author

rynowak commented Aug 3, 2019

So, I found the source of the hang. It's this bug: dotnet/extensions#1363

Basically - calling IHost.StopAsync will deadlock unless someone called dispose. The idea is that calling Dispose starts the cleanup, and StopAsync waits for it to be completed.

@rynowak rynowak force-pushed the rynowak/unskip-my-heart branch from 7b00e0c to 9bb5ac3 Compare August 3, 2019 03:39
rynowak
rynowak commented Aug 3, 2019
View reviewed changes
src/Components/test/E2ETest/Infrastructure/ServerFixtures/ServerFixture.cs
if (edi != null)
{
throw edi.SourceException;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't the cause of any problems, but it will cause the process to fail with a bad error if it ever throws. I saw this while looking for the source of the hang, and wanted to harden it.

@rynowak rynowak merged commit 352df35 into release/3.0 Aug 3, 2019
@ghost ghost deleted the rynowak/unskip-my-heart branch August 3, 2019 15:52
@dougbu
Copy link
Contributor

dougbu commented Aug 3, 2019

@rynowak can #11698 be closed now❔ Many thanks for reducing @JunTaoLuo's burden if so❕

@SteveSandersonMS
Copy link
Member

rynowak merged commit 352df35 into release/3.0 2 days ago

I say again: at last!

@rynowak
Copy link
Member Author

rynowak commented Aug 5, 2019

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn left review comments

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rynowak @dougbu @SteveSandersonMS @javiercn @Pilchie