-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Expand Blazor logging and diagnostics #11792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rynowak Do you have a view on which parts of this should be handled using It would be convenient to use Unless there are reasons, I expect to follow the same patterns for this as in the SignalR code. |
diagnostics source is a lower level construct I believe, for way lower level tracing. ILogger afaik is good enough. |
Let's just do |
The non-JS-interop parts of this are now done, so I'm unassigning myself and leaving the JS interop bits with @javiercn. |
Closing this as the changes have been included in #12250 which will be merged with the rest of the dependencies |
This is part of #10472
Ensure developers can trace all the major things that happen in a server-side Blazor application (e.g., circuits starting/ending) with a special focus on all incoming calls from the client (event notifications, JSInterop calls, renderbatch ACKs).
InternalInvokeAsync
onRemoteJSRuntime
that only the framework calls and is not on theIJSRuntime
interface.@page
component or if no match was foundThis assumes it's possible to do such fine-grained logging without any meaningful perf cost (at least, when the logging level is such that the messages are being skipped). If this does turn out to have a meaningful perf cost, we wouldn't want to do all the per-component parts under "rendering".
The text was updated successfully, but these errors were encountered: