-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Revert tests skipped due to Nullable changes #11813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
dougbu
pushed a commit
that referenced
this issue
Jul 4, 2019
* Update usage of `@ref` - thanx @rynowak❕ * Use suppressField x2 - thanx @rynowak❕ * Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190703.8 - Microsoft.NET.Sdk.Razor - 3.0.0-preview8.19353.8 - Microsoft.CodeAnalysis.Razor - 3.0.0-preview8.19353.8 - Microsoft.AspNetCore.Razor.Language - 3.0.0-preview8.19353.8 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview8.19353.8 * Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190703.14 - Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview8.19353.14 - Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview8.19353.14 - dotnet-ef - 3.0.0-preview8.19353.14 - Microsoft.EntityFrameworkCore - 3.0.0-preview8.19353.14 - Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview8.19353.14 - Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview8.19353.14 - Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview8.19353.14 Dependency coherency updates - Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.Memory - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.AzureKeyVault - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Binder - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.CommandLine - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.FileExtensions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Ini - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Json - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.KeyPerFile - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.UserSecrets - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Xml - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DependencyInjection.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DependencyInjection - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DiagnosticAdapter - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Diagnostics.HealthChecks - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Composite - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Embedded - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Physical - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileSystemGlobbing - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Hosting.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Hosting - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Http - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Localization.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Localization - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Abstractions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.AzureAppServices - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Configuration - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Console - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Debug - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.EventSource - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.EventLog - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.TraceSource - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Testing - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ObjectPool - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Options.ConfigurationExtensions - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Options.DataAnnotations - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Options - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ParameterDefaultValue.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Primitives - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.TypeNameHelper.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ValueStopwatch.Sources - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.WebEncoders - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Internal.Extensions.Refs - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.JSInterop - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Mono.WebAssembly.Interop - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.CSharp - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Win32.Registry - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.ComponentModel.Annotations - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Diagnostics.EventLog - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.IO.Pipelines - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Net.Http.WinHttpHandler - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Net.WebSockets.WebSocketProtocol - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Reflection.Metadata - 1.7.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Runtime.CompilerServices.Unsafe - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Security.Cryptography.Cng - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Security.Cryptography.Pkcs - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Security.Cryptography.Xml - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Security.Permissions - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Security.Principal.Windows - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.ServiceProcess.ServiceController - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Text.Encodings.Web - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Text.Json - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - System.Threading.Channels - 4.6.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DependencyModel - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.NETCore.App.Ref - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - NETStandard.Library.Ref - 2.1.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.NETCore.Platforms - 3.0.0-preview8.19353.3 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27903-07 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Internal.AspNetCore.Analyzers - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) - Microsoft.AspNetCore.Testing - 3.0.0-preview8.19353.10 (parent: Microsoft.EntityFrameworkCore) * React to JSInterop changes - thanx @pranavkm❕ * Apply fix for analyzer problem - copy fix done in 006b002 (which should be merged from release/3.0-preview7 soon) * Skip tests per #11813 - cherry-picked from 006b002
rynowak
added a commit
that referenced
this issue
Jul 17, 2019
Fixed by: #12202 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The C# compiler has changed the metadata format used to represent nullability information in preview 7. Since this has changed, we don't detect any of the new patterns, and so our features for inferring required attribute don't work.
Tests skipped due to changes in preview7.
The text was updated successfully, but these errors were encountered: