Skip to content

In ComponentHub.StartCircuit, prevent creating multiple circuits #11841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SteveSandersonMS opened this issue Jul 3, 2019 · 2 comments
Closed
Assignees
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. ✔️ Resolution: Duplicate Resolved as a duplicate of another issue

Comments

@SteveSandersonMS
Copy link
Member

From #11791

Currently, a badly-behaved client could call the ComponentHub.StartCircuit hub method and create as many circuits as they want from within a single connection. We should check whether the hub instance already has an associated circuit host, and if so, reject this.

Similarly, check the ConnectCircuit to verify we're doing the right thing if a bad client calls it multiple times. It looks like it's meant to be allowed to call this even if you're already connected (presumably because the client can't know for sure if a previous reconnect attempt succeeded just a moment ago), but can we more cleanly no-op in this case? Can we have a comment to say what's meant to happen if a client calls this unexpectedly?

@javiercn
Copy link
Member

javiercn commented Jul 3, 2019

My PR for connection Id tweaks already addressed this. Feel free to give this to me and I’ll take out the cookie part if necessary.

@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Jul 3, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview9 milestone Jul 3, 2019
@mkArtakMSFT
Copy link
Member

Dupe of #12054

@mkArtakMSFT mkArtakMSFT added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label Jul 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. ✔️ Resolution: Duplicate Resolved as a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants