Skip to content

[Blazor] StartCircuit should check for an existing circuit. #12054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiercn opened this issue Jul 10, 2019 · 3 comments
Closed

[Blazor] StartCircuit should check for an existing circuit. #12054

javiercn opened this issue Jul 10, 2019 · 3 comments
Assignees
@javiercn
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview8

Comments

@javiercn
Copy link
Member

We should not allow StartCircuit to be called more than once and in case a circuit exists, simply render any non prerendered component and return.

Otherwise I can create multiple circuits by just spamming StartCircuit.
@rynowak
Copy link
Member

rynowak commented Jul 10, 2019

What data do you have that helps us understand the priority of this?

@rynowak rynowak added the area-blazor Includes: Blazor, Razor Components label Jul 10, 2019
@javiercn
Copy link
Member Author

I invoked StartCircuit repeatedly with Ignitor and saw it create multiple circuits.

@javiercn
Copy link
Member Author

image

@mkArtakMSFT mkArtakMSFT mentioned this issue Jul 10, 2019
Closed
31 tasks
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Jul 12, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview9 milestone Jul 12, 2019
@mkArtakMSFT mkArtakMSFT mentioned this issue Jul 17, 2019
Closed
javiercn added a commit that referenced this issue Jul 18, 2019
@javiercn
[Blazor][Fixes #12054] ComponentHub reliability improvements.
0b262cc 
* Validates StartCircuit is called once per circuit.
* NOOPs when other hub methods are called before start circuit and
  returns an error to the client.
javiercn added a commit that referenced this issue Jul 19, 2019
@javiercn
[Blazor][Fixes #12054] ComponentHub reliability improvements.
e8c99b2 
* Validates StartCircuit is called once per circuit.
* NOOPs when other hub methods are called before start circuit and
  returns an error to the client.
@javiercn javiercn added Done This issue has been fixed and removed Working labels Jul 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@javiercn javiercn

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview8
Development

No branches or pull requests
3 participants
@rynowak @javiercn @mkArtakMSFT