Skip to content

Remove temporary logic from BindMethods.DispatchEventAsync #11846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SteveSandersonMS opened this issue Jul 3, 2019 · 1 comment
Closed

Remove temporary logic from BindMethods.DispatchEventAsync #11846

SteveSandersonMS opened this issue Jul 3, 2019 · 1 comment
Assignees
@rynowak
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed task
Milestone
3.0.0-preview8

Comments

@SteveSandersonMS
Copy link
Member

From #11791

BindMethods.DispatchEventAsync has a comment saying "this is a temporary polyfill that doesn't do proper error handling and will be removed".

Are we able to remove this now?
@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Jul 3, 2019
@SteveSandersonMS SteveSandersonMS mentioned this issue Jul 3, 2019
Closed
47 tasks
@rynowak
Copy link
Member

rynowak commented Jul 3, 2019

One place this is called from is BindMethods.DispatchEventAsync, which comes with a comment saying "this is a temporary polyfill that doesn't do proper error handling and will be removed". Can this be removed now

Yes, this can be removed along with all of the overloads of SetValueHandler

@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview8 milestone Jul 3, 2019
rynowak added a commit that referenced this issue Jul 3, 2019
@rynowak
Remove obsolete BindMethods code
c0bdda9 
Fixes: #11846
rynowak added a commit that referenced this issue Jul 3, 2019
@rynowak
Remove obsolete BindMethods code
ca2e99f 
Fixes: #11846
@rynowak rynowak closed this as completed in de91125 Jul 4, 2019
@mkArtakMSFT mkArtakMSFT added the Done This issue has been fixed label Jul 8, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed task
Projects
None yet
Milestone
3.0.0-preview8
Development

No branches or pull requests
3 participants
@SteveSandersonMS @rynowak @mkArtakMSFT