Skip to content

dnvminstall.sh should check for ~/.bashrc first #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fsoikin opened this issue Dec 18, 2015 · 1 comment
Closed

dnvminstall.sh should check for ~/.bashrc first #1186

fsoikin opened this issue Dec 18, 2015 · 1 comment

Comments

@fsoikin
Copy link

fsoikin commented Dec 18, 2015

As it is currently coded, dnvminstall.sh first tries to add its hooks to ~/.bash_profile, and only if that doesn't exist, goes for ~/.bashrc. This behavior essentially prevents the hooks from working in non-login terminals (such as Gnome-started graphical one), which source ~/.bashrc, but not ~/.bash_profile.

Doing it the other way around would be beneficial, and not harmful, because ~/.bashrc should normally be sourced from ~/.bash_profile, and indeed, it is usually the default.

@aspnet-hello
Copy link

This issue is being closed because it has not been updated in 3 months.

We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.

SteveSandersonMS added a commit that referenced this issue Nov 27, 2018
* Fix empty nonvoid elements in markup blocks. Fixes #1186

* Also update another test
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants