Skip to content

Decide if server-side Blazor needs limits on how many events can be delivered and the max size for events #12003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiercn opened this issue Jul 9, 2019 · 6 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Needs: Design This issue requires design work before implementating.
Milestone

Comments

@javiercn
Copy link
Member

javiercn commented Jul 9, 2019

No description provided.

@analogrelay analogrelay added the area-blazor Includes: Blazor, Razor Components label Jul 9, 2019
@rynowak
Copy link
Member

rynowak commented Jul 9, 2019

Do you have any data or examples of tests that help us understand the priority of this?

@javiercn
Copy link
Member Author

javiercn commented Jul 9, 2019

In process, so far with a client I can cause exceptions on the server

fail: Microsoft.AspNetCore.SignalR.Internal.DefaultHubDispatcher[8]
      Failed to invoke hub method 'BeginInvokeDotNetFromJS'.
System.IO.InvalidDataException: Error binding arguments. Make sure that the types of the provided values match the types of the hub method being invoked.
 ---> System.IO.InvalidDataException: Deserializing object of the `String` type for 'argument' failed.
 ---> System.IO.EndOfStreamException: Attempted to read past the end of the stream.
   at MessagePack.MessagePackReader.GetStringLengthInBytesSlow(Byte code)
   at Microsoft.AspNetCore.Components.Server.BlazorPack.BlazorPackHubProtocol.DeserializeObject(MessagePackReader& reader, Type type, String field) in C:\work\AspNetCore\src\Components\Server\src\BlazorPack\BlazorPackHubProtocol.cs:line 474
   --- End of inner exception stack trace ---
   at Microsoft.AspNetCore.Components.Server.BlazorPack.BlazorPackHubProtocol.DeserializeObject(MessagePackReader& reader, Type type, String field) in C:\work\AspNetCore\src\Components\Server\src\BlazorPack\BlazorPackHubProtocol.cs:line 474
   at Microsoft.AspNetCore.Components.Server.BlazorPack.BlazorPackHubProtocol.BindArguments(MessagePackReader& reader, IReadOnlyList`1 parameterTypes) in C:\work\AspNetCore\src\Components\Server\src\BlazorPack\BlazorPackHubProtocol.cs:line 258
   --- End of inner exception stack trace ---
   at Microsoft.AspNetCore.Components.Server.BlazorPack.BlazorPackHubProtocol.BindArguments(MessagePackReader& reader, IReadOnlyList`1 parameterTypes) in C:\work\AspNetCore\src\Components\Server\src\BlazorPack\BlazorPackHubProtocol.cs:line 265
   at Microsoft.AspNetCore.Components.Server.BlazorPack.BlazorPackHubProtocol.CreateInvocationMessage(MessagePackReader& reader, IInvocationBinder binder, Int32 itemCount) in C:\work\AspNetCore\src\Components\Server\src\BlazorPack\BlazorPackHubProtocol.cs:line 123

And I get the memory from the server to grow up to 3GB

@rynowak
Copy link
Member

rynowak commented Jul 9, 2019

In process, so far with a client

Doesn't SignalR enforce a default limit on the message size from a client?

How will an external client run code in process on a deployed application?

@javiercn
Copy link
Member Author

javiercn commented Jul 9, 2019

In process, so far with a client

I meant with 1 client.

Doesn't SignalR enforce a default limit on the message size from a client?

Yes, I'm playing within those rules. Sending events with 31K. The default signalr message size is 32K

@rynowak
Copy link
Member

rynowak commented Jul 9, 2019

Ok good, this seems relevant then 👍

@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview9 milestone Jul 10, 2019
@mkArtakMSFT mkArtakMSFT added the Needs: Design This issue requires design work before implementating. label Jul 10, 2019
@rynowak rynowak changed the title [Blazor][Server-side] Limit the rate at which events can be delivered and the max size for events Decide if server-side Blazor needs limits on how many events can be delivered and the max size for events Jul 10, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview9, Backlog Jul 15, 2019
@mkArtakMSFT
Copy link
Member

Closing this as we've found out that things look good enough and we don't need to do anything here.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Needs: Design This issue requires design work before implementating.
Projects
None yet
Development

No branches or pull requests

4 participants