Skip to content

[Blazor] Harden start circuit #12057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiercn opened this issue Jul 10, 2019 · 0 comments
Closed

[Blazor] Harden start circuit #12057

javiercn opened this issue Jul 10, 2019 · 0 comments
Assignees
@rynowak
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview9

Comments

@javiercn
Copy link
Member

Sending invalid parameters to start circuit shouldn't cause unhandled exceptions on the server. Instead, we should gracefully return an error to the client.

Otherwise we can spam the log with warnings.
@analogrelay analogrelay added the area-blazor Includes: Blazor, Razor Components label Jul 10, 2019
@mkArtakMSFT mkArtakMSFT mentioned this issue Jul 10, 2019
Closed
31 tasks
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview9 milestone Jul 12, 2019
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. cost: S labels Jul 12, 2019
@rynowak rynowak self-assigned this Jul 20, 2019
rynowak added a commit that referenced this issue Aug 2, 2019
@rynowak
Harden StartCircuit
f6ef021 
Fixes: #12057

Adds some upfront argument validation as well as error handling for
circuit intialization failures.
@rynowak rynowak added the Working label Aug 2, 2019
@rynowak rynowak mentioned this issue Aug 2, 2019
Merged
rynowak added a commit that referenced this issue Aug 2, 2019
@rynowak
Harden StartCircuit
51ba6e8 
Fixes: #12057

Adds some upfront argument validation as well as error handling for
circuit intialization failures.
@dougbu dougbu closed this as completed in d52d7e3 Aug 3, 2019
@mkArtakMSFT mkArtakMSFT added Done This issue has been fixed and removed Working labels Aug 5, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview9
Development

No branches or pull requests
4 participants
@analogrelay @rynowak @javiercn @mkArtakMSFT