-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Components solution does not build due to missing .npmproj #12653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Workaround for: #12653 This isn't a great fix for the this problem but it makes it possible to build the solution. You'll still see errors when you first open the solution but they will go away when VS does a restore. We'll continue the discussion separately about the right fix for this.
Workaround for: #12653 This isn't a great fix for the this problem but it makes it possible to build the solution. You'll still see errors when you first open the solution but they will go away when VS does a restore. We'll continue the discussion separately about the right fix for this.
Workaround for: #12653 This isn't a great fix for the this problem but it makes it possible to build the solution. You'll still see errors when you first open the solution but they will go away when VS does a restore. We'll continue the discussion separately about the right fix for this.
Workaround for: #12653 This isn't a great fix for the this problem but it makes it possible to build the solution. You'll still see errors when you first open the solution but they will go away when VS does a restore. We'll continue the discussion separately about the right fix for this.
Workaround for: #12653 This isn't a great fix for the this problem but it makes it possible to build the solution. You'll still see errors when you first open the solution but they will go away when VS does a restore. We'll continue the discussion separately about the right fix for this.
Hmm, @Pilchie and @pranavkm our AspNetCore.sln file does not contain any |
I don't think sln files can include npmproj files. Projects that depend on the build output of npmproj files manually build them e.g. https://github.com/dotnet/aspnetcore/blob/master/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj#L31-L37 |
@pranavkm should special cases like that work when building in VS❔ Or, are users required to build the |
/ping @pranavkm |
We require users to build the project from the command line before launching in VS. We've tried automating the npm reference and that does not work. |
@captainsafia this issue indicates a gap in the src/Components/README.md file. That file should indicate that executing src/Components/build.cmd before opening Visual Studio is strongly suggested because otherwise the NPM projects will not be up-to-date and the .NET SDK or runtimes may be missing. |
This is failing after the recent changes to fix the build of our node-related projects.
VS doesn't appear to support adding projects with arbitrary
.*proj
file extensions (not an option in the UI, and the commandlinedotnet sln add
rejects it).If I use my l33t hacker skills to edit the sln by hand then I get errors like:
I think we either need to make these project conditional based on VS - or we need to change them to
.msbuildproj
- which is the file extension for general-purpose msbuild-based projects.The text was updated successfully, but these errors were encountered: