Skip to content

[Mvc] Add EventSource tracing to application part discovery #14343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javiercn opened this issue Sep 23, 2019 · 11 comments
Open

[Mvc] Add EventSource tracing to application part discovery #14343

javiercn opened this issue Sep 23, 2019 · 11 comments
Labels
affected-very-few This issue impacts very few customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-mvc-application-model Features related to MVC application model, discovery, application parts severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@javiercn
Copy link
Member

  • Right now this is a common issue that our customer hit regularly.
  • Debugging it manually is hard and time consuming.
  • Adding event source tracing would allow us to quickly see what's going on in different environments and greatly help customers troubleshoot these types of issues.
  • We already do this for other things like dependency injection.
@javiercn
Copy link
Member Author

@rynowak
Copy link
Member

rynowak commented Sep 23, 2019

Do you have some examples of bugs/investigations we could short circuit with this?

@javiercn
Copy link
Member Author

Sample issues this would help troubleshoot
#13850
#10331
#4332

To name a few, but there are more.

With tracing we can answer the following questions:

  • What assembly is being considered as the application entry point.
  • What related parts were found for that assembly.
  • What parts where created from those related assemblies.

@davidfowl
Copy link
Member

Just and FYI the reason DI has to use event source is because logging isn’t possible. Why not just log it as debug?

@javiercn
Copy link
Member Author

It’s not possible either. The container is not yet built at the time it happens.

@davidfowl
Copy link
Member

@javiercn why not log the results instead of logging the process or building those results?

@javiercn
Copy link
Member Author

@davidfowl Because logging information during the process is what it is useful in troubleshooting the issue. When this issue happens the result is typically an empty application parts list, which gives you no clue as to why you ended up there.

@mkArtakMSFT mkArtakMSFT added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Sep 24, 2019
@mkArtakMSFT mkArtakMSFT added this to the 5.0.0-preview1 milestone Sep 24, 2019
@javiercn
Copy link
Member Author

More issues this will help with
#14359
#14374

@mkArtakMSFT
Copy link
Contributor

Moving this to happen now as this will help with future investigations a lot.

@pranavkm pranavkm removed the cost: S label Nov 6, 2020
@javiercn javiercn added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool labels Feb 19, 2021 — with ASP.NET Core Issue Ranking
@javiercn javiercn added the feature-mvc-application-model Features related to MVC application model, discovery, application parts label Apr 18, 2021
@pranavkm pranavkm added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Oct 19, 2021
@rafikiassumani-msft rafikiassumani-msft removed this from the Backlog milestone Dec 28, 2021
@rafikiassumani-msft rafikiassumani-msft added this to the .NET 7 Planning milestone Dec 28, 2021
@ghost
Copy link

ghost commented Dec 28, 2021

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Oct 11, 2022

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Jun 20, 2023
@captainsafia captainsafia modified the milestones: .NET 8 Planning, Backlog Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-very-few This issue impacts very few customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-mvc-application-model Features related to MVC application model, discovery, application parts severity-nice-to-have This label is used by an internal tool
Projects
No open projects
Status: No status
Development

No branches or pull requests

7 participants