View recompilation for assemblies loaded through AssemblyLoadContext does not work

[taori]

Describe the bug

After figuring out that view recompilation only works without debugging now i tried to get it working on RCL views - should this be working or is this not supported yet?

To Reproduce

Steps to reproduce the behavior:

• Create a mvc netcore3.0 app
• Create a RCL
• Load RCL into mvc app, register the parts
• start without debugging
• change views/home/index.cshtml - that should work
• change a view within a RCL - that does not seem to work.

Reproduction

• checkout https://github.com/taori/Sandbox/tree/netcore3-recompilefails
• Debug ComposableWebApplication
• Change Home/Index.cshtml in main project
• Reload
• And then i get the error.
• MyFeature/Page1 should also work if changing content.

Screenshots

Expected behavior

I would expect RCL views to update as well, not just views which are in the main application

[javiercn]

@pranavkm thoughts?

[javiercn]

@taori Seems like you are loading the class libraries at runtime. I'm not sure Razor runtime compilation will work in that scenario. The error you are seeing has to do with the reference not being part of the dependency model (*.deps.json" file) and I'm not sure there's a way around it.

@pranavkm can confirm.

[taori]

@javiercn Hm. Would that not make config.AdditionalReferencePaths kind of obsolete though? That property looks like exactly what i am looking for. Let's see what @pranavkm has to say about this. It would be a shame if this did not work since that would completely break extensibility for what i am trying to do.

The weird thing here is also how i change a view in the main application and the error which appears is another plugin, where i made no changes.

[javiercn]

Ok, I missed something the first time I looked. You need to app the runtime assemblies to the list of application parts, which is what MVC considers when it looks for views, etc.

[javiercn]

Nevermind, I saw that it's behind AddPlugins. That said, I'm not confident in the logic you are using there to configure the parts. You should use ProvideApplicationPartFactoryAttribute and RelatedAssembliesAttribute to intantiate the parts for an assembly and find related parts respectively.

[taori]

Nevermind, I saw that it's behind AddPlugins. That said, I'm not confident in the logic you are using there to configure the parts. You should use ProvideApplicationPartFactoryAttribute and RelatedAssembliesAttribute to intantiate the parts for an assembly and find related parts respectively.

Yep. you found it. That was the suggested way in 2.x and the assemblies loaded so i figured that way is ok. I suppose you are talking about that attribute? Doesn't look like it is in netcore3.0 anymore or are the docs just not up to date? I have not seen any documentation about this attribute but i'll see if someone on github is using this attribute.

[javiercn]

I'm glad I was able to help.

The attribute is in 3.0,

Closing this as there's no action for us to take here.

[taori]

@javiercn but that didn't help? The docs suggest to use adding assembly parts like this and the application is breaking when i edit unrelated cshtml files. I have no idea why both tickets are closed now, since the problem still exists.