Skip to content

Remove HttpClient from the standard DI services list and add it in the template #16929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkArtakMSFT opened this issue Nov 8, 2019 · 4 comments
Closed

Remove HttpClient from the standard DI services list and add it in the template #16929

mkArtakMSFT opened this issue Nov 8, 2019 · 4 comments
Assignees
@ajaybhargavb
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Milestone
blazor-wasm-3.2-p...

Comments

@mkArtakMSFT
Copy link
Contributor

No description provided.

@mkArtakMSFT mkArtakMSFT added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Nov 8, 2019
@mkArtakMSFT mkArtakMSFT added this to the blazor-wasm milestone Nov 8, 2019
@mkArtakMSFT mkArtakMSFT mentioned this issue Nov 8, 2019
Closed
@Regenhardt
Copy link
Contributor

May I try my hand on this one? Seems simple enough.

@mkArtakMSFT
Copy link
Contributor Author

May I try my hand on this one? Seems simple enough.

Thanks for your suggestion, @Regenhardt.
We're quite close to the code-complete date for current milestone. If you can send a PR within a day, we'll consider it. /cc @ajaybhargavb

@Regenhardt Regenhardt mentioned this issue Feb 18, 2020
Merged
@Regenhardt
Copy link
Contributor

Not sure I did everything right, since I couldn't actually get it to run. Probably should have started yesterday, might have eased the whole schedule thing 😅 .

Regenhardt added a commit to Regenhardt/aspnetcore that referenced this issue Feb 19, 2020
@Regenhardt
[Blazor][Wasm] Move HttpClient from default services to extension met…
b0cf257 
…hod (dotnet#16929)
ajaybhargavb pushed a commit that referenced this issue Feb 20, 2020
@Regenhardt @SteveSandersonMS
[Blazor][Wasm] Move HttpClient from default services to Program.Main (#…
6a85855 
…19119)

* [Blazor][Wasm] Move HttpClient from default services to extension method (#16929)

* Apply suggestions from code review

Co-authored-by: Steve Sanderson <[email protected]>
@ajaybhargavb
Copy link
Contributor

Thanks for your contribution, @Regenhardt!

@ajaybhargavb ajaybhargavb added Done This issue has been fixed and removed Working labels Feb 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Milestone
blazor-wasm-3.2-preview2
Development

No branches or pull requests
4 participants
@ajaybhargavb @Regenhardt @ryanbrandenburg @mkArtakMSFT