Skip to content

Identity.UI produce assemblies that are built with implementation assemblies instead of reference assemblies. #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JunTaoLuo opened this issue Jan 14, 2020 · 6 comments
Closed

Identity.UI produce assemblies that are built with implementation assemblies instead of reference assemblies. #18323

JunTaoLuo opened this issue Jan 14, 2020 · 6 comments
Assignees
@pranavkm
Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-identity Includes: Identity and providers feature-identity-ui tell-mode Indicates a PR which is being merged during tell-mode
Milestone
3.1.2

Comments

@JunTaoLuo
Copy link
Contributor

We discovered in 3.1.1 that Identity.UI assemblies. Specifically V3.dll and V4.dll. Combined with the bug described in #17970, runtime errors due to not being able to load the correct assemblies will be produced. Though we are fixing the related issue, we should ensure that the Identity.UI assemblies are built correctly.

The reason why Identity.UI specifically does not build correctly is because the customized logic at https://github.com/dotnet/aspnetcore/blob/release/3.1/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj#L59-L65 where MSBuild is launched to directly invoke the BuildForUI target. This bypasses the logic that we need to trigger at https://github.com/dotnet/aspnetcore/blob/release/3.1/eng/targets/ResolveReferences.targets#L249-L276.

My recommendation would be to try separating out the project into two new project for each of the V3 and V4 content and building them separately in the same way we build the other UI packages. Then compose the final Identity.UI package with the dll produced in the V3 and V4 projects.

cc @pranavkm @mkArtakMSFT to triage.
@JunTaoLuo JunTaoLuo added Servicing-consider Shiproom approval is required for the issue area-identity Includes: Identity and providers feature-identity-ui labels Jan 14, 2020
@JunTaoLuo JunTaoLuo added this to the 3.1.x milestone Jan 14, 2020
@JunTaoLuo
Copy link
Contributor Author

Here's the doc for the known issue in 3.1 https://github.com/aspnet/specs/pull/406/files

@Pilchie
Copy link
Member

Pilchie commented Jan 15, 2020

@mkArtakMSFT - we think this issue will block 3.1.2, and we need to work on a fix for it ASAP. Can you help us find someone who understands the build logic there to investigate ASAP?

@pranavkm
Copy link
Contributor

Picking this up

@pranavkm pranavkm self-assigned this Jan 15, 2020
@Pilchie
Copy link
Member

Pilchie commented Jan 16, 2020

Thanks @pranavkm !

pranavkm added a commit that referenced this issue Jan 16, 2020
@pranavkm
Use reference assemblies when compiling Razor views
463ddb5 
Fixes #18323
@pranavkm pranavkm mentioned this issue Jan 16, 2020
Merged
wtgodbe pushed a commit that referenced this issue Jan 17, 2020
@pranavkm @wtgodbe
Use reference assemblies when compiling Razor views (#18395)
cd518e9 
* Use reference assemblies when compiling Razor views
Fixes #18323

* Avoid mixing runtime and ref assembly
@JunTaoLuo JunTaoLuo removed the Servicing-consider Shiproom approval is required for the issue label Jan 17, 2020
@JunTaoLuo JunTaoLuo modified the milestones: 3.1.x, 3.1.2 Jan 17, 2020
@JunTaoLuo JunTaoLuo added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 17, 2020
@JunTaoLuo
Copy link
Contributor Author

The PR is merged so I'm closing. @pranavkm reopen if you need it to track something else.

@pranavkm
Copy link
Contributor

Verified that this works in 3.1.2 build 014865

@pranavkm pranavkm added the accepted This issue has completed "acceptance" testing (including accessibility) label Jan 27, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-identity Includes: Identity and providers feature-identity-ui tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
3.1.2
Development

No branches or pull requests
3 participants
@pranavkm @Pilchie @JunTaoLuo